Throw AbstractClassInstantiationError on abstract classes.

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.body_builder;
 
 import '../parser/parser.dart' show FormalParameterType, optional;
 
 import '../parser/error_kind.dart' show ErrorKind;
 
@@ skipping 1681 matching lines @@
     push(type);
     push(typeArguments ?? NullValue.TypeArguments);
     push(name);
   }
 
   @override
   Expression buildStaticInvocation(Member target, Arguments arguments,
       {bool isConst: false, int charOffset: -1}) {
     List<TypeParameter> typeParameters = target.function.typeParameters;
     if (target is Constructor) {
+      assert(!target.enclosingClass.isAbstract);
       typeParameters = target.enclosingClass.typeParameters;
     }
     if (!checkArguments(target.function, arguments, typeParameters)) {
       return throwNoSuchMethodError(target.name.name, arguments, charOffset);
     }
     if (target is Constructor) {
       return new ConstructorInvocation(target, arguments)
         ..isConst = isConst
         ..fileOffset = charOffset;
     } else {
@@ skipping 73 matching lines @@
       }
 
       String errorName;
       if (type is ClassBuilder) {
         Builder b = type.findConstructorOrFactory(name);
         Member target;
         if (b == null) {
           // Not found. Reported below.
         } else if (b.isConstructor) {
           if (type.isAbstract) {
-            // TODO(ahe): Generate abstract instantiation error.
+            push(evaluateArgumentsBefore(
+                arguments,
+                buildAbstractClassInstantiationError(
+                    type.name, nameToken.charOffset)));
+            return;
           } else {
             target = b.target;
           }
         } else if (b.isFactory) {
           target = getRedirectionTarget(b.target);
           if (target == null) {
             push(buildCompileTimeError(
                 "Cyclic definition of factory '${name}'.",
                 nameToken.charOffset));
             return;
@@ skipping 556 matching lines @@
     }
     return super.handleUnrecoverableError(token, kind, arguments);
   }
 
   @override
   Expression buildCompileTimeError(error, [int charOffset = -1]) {
     addCompileTimeError(charOffset, error);
     String message = formatUnexpected(uri, charOffset, error);
     Builder constructor = library.loader.getCompileTimeError();
     return new Throw(buildStaticInvocation(constructor.target,
-        new Arguments(<Expression>[new StringLiteral(message)]),
-        isConst: false)); // TODO(ahe): Make this const.
+        new Arguments(<Expression>[new StringLiteral(message)])));
+  }
+
+  Expression buildAbstractClassInstantiationError(String className,
+      [int charOffset = -1]) {
+    warning("The class '$className' is abstract and can't be instantiated.",
+        charOffset);
+    Builder constructor = library.loader.getAbstractClassInstantiationError();
+    return new Throw(buildStaticInvocation(constructor.target,
+        new Arguments(<Expression>[new StringLiteral(className)])));
   }
 
   Statement buildCompileTimeErrorStatement(error, [int charOffset = -1]) {
     return new ExpressionStatement(buildCompileTimeError(error, charOffset));
   }
 
   @override
   Initializer buildCompileTimeErrorIntializer(error, [int charOffset = -1]) {
     return new LocalInitializer(new VariableDeclaration.forValue(
         buildCompileTimeError(error, charOffset)));
@@ skipping 33 matching lines @@
 
   @override
   void warning(String message, [int charOffset = -1]) {
     if (constantExpressionRequired) {
       addCompileTimeError(charOffset, message);
     } else {
       super.warning(message, charOffset);
     }
   }
 
+  Expression evaluateArgumentsBefore(
+      Arguments arguments, Expression expression) {
+    if (arguments == null) return expression;
+    List<Expression> expressions =
+        new List<Expression>.from(arguments.positional);
+    for (NamedExpression named in arguments.named) {
+      expressions.add(named.value);
+    }
+    for (Expression argument in expressions.reversed) {
+      expression = new Let(
+          new VariableDeclaration.forValue(argument, isFinal: true),
+          expression);
+    }
+    return expression;
+  }
+
   @override
   void debugEvent(String name) {
     // printEvent(name);
   }
 }
 
 // TODO(ahe): Shouldn't need to be an expression.
 class UnresolvedIdentifier extends InvalidExpression {
   final Name name;
 
@@ skipping 460 matching lines @@
   } else if (node is PrefixBuilder) {
     return node.name;
   } else if (node is ThisAccessor) {
     return node.isSuper ? "super" : "this";
   } else if (node is FastaAccessor) {
     return node.plainNameForRead;
   } else {
     return internalError("Unhandled: ${node.runtimeType}");
   }
 }