Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2781453004: Separate module min memory pages counter for asm.js/WASM. (Closed)

Created:
3 years, 8 months ago by kschimpf
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Separate module min memory pages counter for asm.js/WASM. Currently, V8 uses the same size counter to measure the minimum number of memory pages allocated by a module for both asm.js and WASM. This CL separates the counter into two separate counters, and then uses the appropriate counter when measuring. BUG=chromium:704922 R=mtrofin@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2781453004 Cr-Commit-Position: refs/heads/master@{#44204} Committed: https://chromium.googlesource.com/v8/v8/+/1d4821280b2e09292e80d873dfff816939809c69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/counters.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
kschimpf
Please review. Thanks!
3 years, 8 months ago (2017-03-28 16:07:11 UTC) #5
bradnelson
lgtm
3 years, 8 months ago (2017-03-28 18:12:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781453004/1
3 years, 8 months ago (2017-03-28 18:13:01 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 18:14:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1d4821280b2e09292e80d873dfff8169398...

Powered by Google App Engine
This is Rietveld 408576698