Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2781443003: Fix #28120, strong mode allows field overrides (Closed)
Patch Set: fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/test/browser/language_tests.js
diff --git a/pkg/dev_compiler/test/browser/language_tests.js b/pkg/dev_compiler/test/browser/language_tests.js
index 6d9d188954b364cb16c1d08747ab27a0aae03642..69ca0e98fc8887e8f0ccc618d5dbf8923d9e54bc 100644
--- a/pkg/dev_compiler/test/browser/language_tests.js
+++ b/pkg/dev_compiler/test/browser/language_tests.js
@@ -308,6 +308,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'error_stack_trace1_test': fail,
'error_stack_trace2_test': fail,
'for_in_test': is.firefox('<=50') ? fail : pass,
+ 'growable_list_test': fail,
'hash_map2_test': skip_timeout,
'hash_set_test_01_multi': fail,
'hidden_library2_test_01_multi': fail,
@@ -359,7 +360,6 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
// TODO(rnystrom): Times out because it tests a huge number of
// combinations of URLs (4 * 5 * 5 * 8 * 6 * 6 * 4 = 115200).
'uri_parse_test': skip_timeout,
-
// this is timing out on Chrome Canary only
// pinning this skip in case it's a transient canary issue
'uri_test': is.chrome('59') ? ['skip'] : ['slow'],
@@ -665,6 +665,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'relation_assignable_test': fail,
'relation_subtype_test': fail,
'set_field_with_final_test': fail,
+ 'set_field_with_final_inheritance_test': fail,
'symbol_validation_test_01_multi': fail,
'symbol_validation_test_none_multi': fail,
'to_string_test': fail,
« no previous file with comments | « pkg/dev_compiler/lib/src/compiler/property_model.dart ('k') | pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698