Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js

Issue 2781443003: Fix #28120, strong mode allows field overrides (Closed)
Patch Set: fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/test/browser/language_tests.js ('k') | pkg/dev_compiler/test/codegen_expected/closure.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js
diff --git a/pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js b/pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js
index 803a049d772766da0e1b3b8416c9025bf42ca0b9..ce511defea2eb68be93708af558f118192342ac0 100644
--- a/pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js
+++ b/pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js
@@ -32,8 +32,14 @@ define(['dart_sdk'], function(dart_sdk) {
names: ['equals', 'listEquals']
});
BenchmarkBase$.BenchmarkBase = class BenchmarkBase extends core.Object {
+ get name() {
+ return this[name$];
+ }
+ set name(value) {
+ super.name = value;
+ }
new(name) {
- this.name = name;
+ this[name$] = name;
}
run() {}
warmup() {
@@ -75,6 +81,7 @@ define(['dart_sdk'], function(dart_sdk) {
core.print(dart.str`${this.name}(RunTime): ${score} us.`);
}
};
+ const name$ = Symbol("BenchmarkBase.name");
dart.setSignature(BenchmarkBase$.BenchmarkBase, {
fields: () => ({name: core.String}),
methods: () => ({
« no previous file with comments | « pkg/dev_compiler/test/browser/language_tests.js ('k') | pkg/dev_compiler/test/codegen_expected/closure.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698