Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2781363004: Revert of MD Settings: long dialog body should have overscroll line. (Closed)

Created:
3 years, 8 months ago by stgao
Modified:
3 years, 8 months ago
Reviewers:
scottchen, stevenjb, dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MD Settings: long dialog body should have overscroll line. (patchset #9 id:180001 of https://codereview.chromium.org/2702523005/ ) Reason for revert: Failed CrElementsDialogTest.All on Waterfall https://findit-for-me.appspot.com/waterfall/failure?url=https%3A%2F%2Fbuild.chromium.org%2Fp%2Fchromium.linux%2Fbuilders%2FLinux%2520Tests%2Fbuilds%2F54060 Original issue's description: > MD Settings: long dialog body should have overscroll line. > > BUG=684152 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2702523005 > Cr-Commit-Position: refs/heads/master@{#460937} > Committed: https://chromium.googlesource.com/chromium/src/+/27793e2b00cd4f06e24cde9599be5693006ed02b TBR=dpapad@chromium.org,stevenjb@chromium.org,scottchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=684152 Review-Url: https://codereview.chromium.org/2781363004 Cr-Commit-Position: refs/heads/master@{#460967} Committed: https://chromium.googlesource.com/chromium/src/+/808ae591999af99f6ada8ceeb73c28e6d27a55f8

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
stgao
Created Revert of MD Settings: long dialog body should have overscroll line.
3 years, 8 months ago (2017-03-31 01:00:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781363004/1
3 years, 8 months ago (2017-03-31 01:01:40 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 01:06:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/808ae591999af99f6ada8ceeb73c...

Powered by Google App Engine
This is Rietveld 408576698