Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2781363003: Respect UTF-8 detection result for local file resources (Closed)

Created:
3 years, 8 months ago by Jinsuk Kim
Modified:
3 years, 8 months ago
Reviewers:
tkent
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Respect UTF-8 detection result for local file resources https://crbug.com/2697213002 (not guessing UTF8 encoding) doesn't have to be applied to local file resources. This CL makes such cases an exception to the policy. BUG=704800 NOTRY=true NOPRESUBMIT=true TBR=tkent@chromium.org Review-Url: https://codereview.chromium.org/2784483003 Cr-Commit-Position: refs/heads/master@{#460573} (cherry picked from commit 31472d1f58ffa076a5697e22aded98f2adde994a) Review-Url: https://codereview.chromium.org/2781363003 . Cr-Commit-Position: refs/branch-heads/3029@{#505} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/f99097de4e9282a1426f184be1078b84f6a08f18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/text/TextEncodingDetector.cpp View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextEncodingDetectorTest.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Jinsuk Kim
Committed patchset #1 (id:1) manually as f99097de4e9282a1426f184be1078b84f6a08f18.
3 years, 8 months ago (2017-03-31 00:44:24 UTC) #2
tkent
3 years, 8 months ago (2017-03-31 00:53:11 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698