Build third_party/zlib/google only when build_with_chromium is true.

Build third_party/zlib/google only when build_with_chromium is true.

This lets other projects reuse the plain parts of third_party/zlib
without depending on Chromium's base/.

BUG=541704
Review-Url: https://codereview.chromium.org/2781353002
Cr-Commit-Position: refs/heads/master@{#460863}
Committed: https://chromium.googlesource.com/chromium/src/+/da0685cc8b20ccce91494583f91aa4a8723ad7c3

[Lei Zhang, 2017-03-30 09:46:23]

Description was changed from

==========
Build third_party/zlib/google only when build_with_chromium is true.

This lets other projects reuse third_party/zlib without depending
on Chromium's base/.

BUG=541704
==========

to

==========
Build third_party/zlib/google only when build_with_chromium is true.

This lets other projects reuse the plain parts of third_party/zlib
without depending on Chromium's base/.

BUG=541704
==========

[Lei Zhang, 2017-03-30 09:46:27]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 09:46:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 11:32:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 11:32:48]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-03-30 19:00:25]

thestig@chromium.org changed reviewers:
+ asvitkine@chromium.org, msarett@chromium.org

[Lei Zhang, 2017-03-30 19:00:25]

I'd like to reuse third_party/zlib in other projects, without the Chromium
specific bits.

[Lei Zhang, 2017-03-30 19:10:47]

On 2017/03/30 19:00:25, Lei Zhang wrote:
> I'd like to reuse third_party/zlib in other projects, without the Chromium
> specific bits.

As an example, https://pdfium-review.googlesource.com/3350 will work once this
lands and we roll to the updated commit hash in that CL.

[Alexei Svitkine (slow), 2017-03-30 19:23:57]

lgtm

[Lei Zhang, 2017-03-30 19:28:26]

msarett: Need your approval too since BUILD.gn is out scope for Alexei's
approval powers.

[msarett1, 2017-03-30 19:48:37]

lgtm

[Lei Zhang, 2017-03-30 20:25:24]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-03-30 20:26:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 20:32:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490905524775400, "parent_rev":
"d26bf4eee20da2e4facbbf1767b05627a6808484", "commit_rev":
"da0685cc8b20ccce91494583f91aa4a8723ad7c3"}

[commit-bot: I haz the power, 2017-03-30 20:37:09]

Description was changed from

==========
Build third_party/zlib/google only when build_with_chromium is true.

This lets other projects reuse the plain parts of third_party/zlib
without depending on Chromium's base/.

BUG=541704
==========

to

==========
Build third_party/zlib/google only when build_with_chromium is true.

This lets other projects reuse the plain parts of third_party/zlib
without depending on Chromium's base/.

BUG=541704

Review-Url: https://codereview.chromium.org/2781353002
Cr-Commit-Position: refs/heads/master@{#460863}
Committed:
https://chromium.googlesource.com/chromium/src/+/da0685cc8b20ccce91494583f91a...
==========

[commit-bot: I haz the power, 2017-03-30 20:37:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da0685cc8b20ccce91494583f91a...