Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: chrome/android/java/res/layout/data_usage_breakdown_row.xml

Issue 2781323004: Create a new Data Saver settings page that adds the site breakdown (Closed)
Patch Set: one preference to inflate two different layouts Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/data_usage_breakdown_row.xml
diff --git a/chrome/android/java/res/layout/data_usage_breakdown_row.xml b/chrome/android/java/res/layout/data_usage_breakdown_row.xml
new file mode 100644
index 0000000000000000000000000000000000000000..f1dfe86ed5d6e32dc3e338c1049f32bebf45a49f
--- /dev/null
+++ b/chrome/android/java/res/layout/data_usage_breakdown_row.xml
@@ -0,0 +1,45 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2017 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<TableRow
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ xmlns:settings="http://schemas.android.com/apk/res-auto"
+ android:id="@+id/site_row"
+ android:layout_width="match_parent">
+
+ <TextView
+ android:id="@+id/site_hostname"
+ android:layout_height="wrap_content"
+ android:layout_width="0dp"
+ android:layout_weight="0"
+ android:paddingBottom="10dp"
+ android:paddingTop="10dp"
+ android:paddingEnd="10dp"
+ android:singleLine="true"
Theresa 2017/04/03 15:05:20 Same comment about a style rule here.
megjablon 2017/04/03 20:33:44 Done.
+ android:textColor="?android:attr/textColorPrimary"
+ android:textSize="14sp" />
+ <TextView
Theresa 2017/04/03 15:05:20 nit: blank line above this one and the other <Text
megjablon 2017/04/03 20:33:44 Done.
+ android:id="@+id/site_data_used"
+ android:layout_height="wrap_content"
+ android:layout_width="wrap_content"
+ android:gravity="end"
+ android:paddingBottom="10dp"
+ android:paddingTop="10dp"
+ android:paddingStart="10dp"
Theresa 2017/04/03 15:05:20 nit: Can this be paddingStart 10dp w/ no paddingEn
megjablon 2017/04/03 20:33:44 Done.
+ android:singleLine="true"
+ android:textColor="?android:attr/textColorPrimary"
+ android:textSize="14sp" />
+ <TextView
+ android:id="@+id/site_data_saved"
+ android:layout_height="wrap_content"
+ android:layout_width="wrap_content"
+ android:gravity="end"
+ android:paddingBottom="10dp"
+ android:paddingTop="10dp"
+ android:paddingStart="24dp"
+ android:singleLine="true"
+ android:textColor="?android:attr/textColorPrimary"
+ android:textSize="14sp" />
+</TableRow>

Powered by Google App Engine
This is Rietveld 408576698