chrome/android/java/res/layout/data_usage_breakdown_row.xml - Issue 2781323004: Create a new Data Saver settings page that adds the site breakdown

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/data_usage_breakdown_row.xml

Issue 2781323004: Create a new Data Saver settings page that adds the site breakdown (Closed)

Patch Set: one preference to inflate two different layouts Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/data_usage_breakdown.xml ('K') | « chrome/android/java/res/layout/data_usage_breakdown.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <TableRow

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:settings="http://schemas.android.com/apk/res-auto"

	9 android:id="@+id/site_row"

	10 android:layout_width="match_parent">

	11

	12 <TextView

	13 android:id="@+id/site_hostname"

	14 android:layout_height="wrap_content"

	15 android:layout_width="0dp"

	16 android:layout_weight="0"

	17 android:paddingBottom="10dp"

	18 android:paddingTop="10dp"

	19 android:paddingEnd="10dp"

	20 android:singleLine="true"
	Theresa 2017/04/03 15:05:20 Same comment about a style rule here. Same comment about a style rule here. megjablon 2017/04/03 20:33:44 Done. Show quoted text On 2017/04/03 15:05:20, Theresa wrote: > Same comment about a style rule here. Done.
	21 android:textColor="?android:attr/textColorPrimary"

	22 android:textSize="14sp" />

	23 <TextView
	Theresa 2017/04/03 15:05:20 nit: blank line above this one and the other <Text nit: blank line above this one and the other <TextView below megjablon 2017/04/03 20:33:44 Done. Show quoted text On 2017/04/03 15:05:20, Theresa wrote: > nit: blank line above this one and the other <TextView below Done.
	24 android:id="@+id/site_data_used"

	25 android:layout_height="wrap_content"

	26 android:layout_width="wrap_content"

	27 android:gravity="end"

	28 android:paddingBottom="10dp"

	29 android:paddingTop="10dp"

	30 android:paddingStart="10dp"
	Theresa 2017/04/03 15:05:20 nit: Can this be paddingStart 10dp w/ no paddingEn nit: Can this be paddingStart 10dp w/ no paddingEnd on the previous TextView for consistency with the TextView below. megjablon 2017/04/03 20:33:44 Done. Show quoted text On 2017/04/03 15:05:20, Theresa wrote: > nit: Can this be paddingStart 10dp w/ no paddingEnd on the previous TextView for > consistency with the TextView below. Done.
	31 android:singleLine="true"

	32 android:textColor="?android:attr/textColorPrimary"

	33 android:textSize="14sp" />

	34 <TextView

	35 android:id="@+id/site_data_saved"

	36 android:layout_height="wrap_content"

	37 android:layout_width="wrap_content"

	38 android:gravity="end"

	39 android:paddingBottom="10dp"

	40 android:paddingTop="10dp"

	41 android:paddingStart="24dp"

	42 android:singleLine="true"

	43 android:textColor="?android:attr/textColorPrimary"

	44 android:textSize="14sp" />

	45 </TableRow>

OLD	NEW