Rename functions in video frame to comply with Style Guide

media/base/video_frame.h

Index: media/base/video_frame.h
diff --git a/media/base/video_frame.h b/media/base/video_frame.h
index 0ae2d706ca7e7a4fd4730d0fac5aa8d52f8e2050..c4dc023752cb7ffe2aeaf67d7d51ac35013eb8dd 100644
--- a/media/base/video_frame.h
+++ b/media/base/video_frame.h
@@ -63,9 +63,7 @@ class MEDIA_EXPORT VideoFrame : public base::RefCountedThreadSafe<VideoFrame> {
     STORAGE_OWNED_MEMORY = 3,  // VideoFrame has allocated its own data buffer.
     STORAGE_SHMEM = 4,         // Pixels are backed by Shared Memory.
 #if defined(OS_LINUX)
-    // TODO(mcasas): Consider turning this type into STORAGE_NATIVE or another
-    // meaningful name and handle it appropriately in all cases.
-    STORAGE_DMABUFS = 5,  // Each plane is stored into a DmaBuf.
+    STORAGE_NATIVE = 5,  // Each plane is stored into a DmaBuf.

[chfremer, 2017/03/30 17:55:44]

Why is STORAGE_NATIVE a more appropriate name than STORAGE_DMABUFS? It seems
less specific. Are there cases where this is used with non-DMA buffers? 

[Uzair, 2017/03/31 10:09:19]

Updated the name as per comment mentioned, but yes your right STORAGE_DMABUFS
looks better as i am not aware of any cases where this is used with non-DMA
buffers.

 #endif
     STORAGE_MOJO_SHARED_BUFFER = 6,
     STORAGE_LAST = STORAGE_MOJO_SHARED_BUFFER,
@@ -339,8 +337,7 @@ class MEDIA_EXPORT VideoFrame : public base::RefCountedThreadSafe<VideoFrame> {
 #if defined(OS_LINUX)
   // Returns backing DmaBuf file descriptor for given |plane|, if present, or
   // -1 if not.
-  // TODO(mcasas): Rename to DmabufFd() to comply with Style Guide.
-  int dmabuf_fd(size_t plane) const;
+  int DmabufFd(size_t plane) const;

[chfremer, 2017/03/30 17:55:44]

If we do not want to be as specific as saying "DMA buffers" in the enum value
above, should we also make the name of this method more general?

[Uzair, 2017/03/31 10:09:19]

Changed above as i am not aware of any Non DMA buffer cases where it might be
used.

 
   // Duplicates internally the |fds_in|, overwriting the current ones. Returns
   // false if something goes wrong, and leaves all internal fds closed.
@@ -351,8 +348,7 @@ class MEDIA_EXPORT VideoFrame : public base::RefCountedThreadSafe<VideoFrame> {
 
 #if defined(OS_MACOSX)
   // Returns the backing CVPixelBuffer, if present.
-  // TODO(mcasas): Rename to CvPixelBuffer() to comply with Style Guide.
-  CVPixelBufferRef cv_pixel_buffer() const;
+  CVPixelBufferRef CvPixelBuffer() const;
 #endif
 
   // Sets the mailbox release callback.