Rename functions in video frame to comply with Style Guide

media/base/video_frame.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_VIDEO_FRAME_H_
 #define MEDIA_BASE_VIDEO_FRAME_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 45 matching lines @@
   // memory.
   // Note that VideoFrames of any StorageType can also have Texture backing,
   // with "classical" GPU Driver-only textures identified as STORAGE_OPAQUE.
   enum StorageType {
     STORAGE_UNKNOWN = 0,
     STORAGE_OPAQUE = 1,  // We don't know how VideoFrame's pixels are stored.
     STORAGE_UNOWNED_MEMORY = 2,  // External, non owned data pointers.
     STORAGE_OWNED_MEMORY = 3,  // VideoFrame has allocated its own data buffer.
     STORAGE_SHMEM = 4,         // Pixels are backed by Shared Memory.
 #if defined(OS_LINUX)
-    // TODO(mcasas): Consider turning this type into STORAGE_NATIVE or another
-    // meaningful name and handle it appropriately in all cases.
-    STORAGE_DMABUFS = 5,  // Each plane is stored into a DmaBuf.
+    STORAGE_NATIVE = 5,  // Each plane is stored into a DmaBuf.

[chfremer, 2017/03/30 17:55:44]

Why is STORAGE_NATIVE a more appropriate name than STORAGE_DMABUFS? It seems
less specific. Are there cases where this is used with non-DMA buffers? 

[Uzair, 2017/03/31 10:09:19]

Updated the name as per comment mentioned, but yes your right STORAGE_DMABUFS
looks better as i am not aware of any cases where this is used with non-DMA
buffers.

 #endif
     STORAGE_MOJO_SHARED_BUFFER = 6,
     STORAGE_LAST = STORAGE_MOJO_SHARED_BUFFER,
   };
 
   // CB to be called on the mailbox backing this frame when the frame is
   // destroyed.
   typedef base::Callback<void(const gpu::SyncToken&)> ReleaseMailboxCB;
 
   // Interface representing client operations on a SyncToken, i.e. insert one in
@@ skipping 253 matching lines @@
 
   // Returns the shared-memory handle, if present
   base::SharedMemoryHandle shared_memory_handle() const;
 
   // Returns the offset into the shared memory where the frame data begins.
   size_t shared_memory_offset() const;
 
 #if defined(OS_LINUX)
   // Returns backing DmaBuf file descriptor for given |plane|, if present, or
   // -1 if not.
-  // TODO(mcasas): Rename to DmabufFd() to comply with Style Guide.
-  int dmabuf_fd(size_t plane) const;
+  int DmabufFd(size_t plane) const;

[chfremer, 2017/03/30 17:55:44]

If we do not want to be as specific as saying "DMA buffers" in the enum value
above, should we also make the name of this method more general?

[Uzair, 2017/03/31 10:09:19]

Changed above as i am not aware of any Non DMA buffer cases where it might be
used.

 
   // Duplicates internally the |fds_in|, overwriting the current ones. Returns
   // false if something goes wrong, and leaves all internal fds closed.
   bool DuplicateFileDescriptors(const std::vector<int>& fds_in);
 #endif
 
   void AddSharedMemoryHandle(base::SharedMemoryHandle handle);
 
 #if defined(OS_MACOSX)
   // Returns the backing CVPixelBuffer, if present.
-  // TODO(mcasas): Rename to CvPixelBuffer() to comply with Style Guide.
-  CVPixelBufferRef cv_pixel_buffer() const;
+  CVPixelBufferRef CvPixelBuffer() const;
 #endif
 
   // Sets the mailbox release callback.
   //
   // The callback may be run from ANY THREAD, and so it is up to the client to
   // ensure thread safety.
   //
   // WARNING: This method is not thread safe; it should only be called if you
   // are still the only owner of this VideoFrame.
   void SetReleaseMailboxCB(const ReleaseMailboxCB& release_mailbox_cb);
@@ skipping 188 matching lines @@
   const int unique_id_;
 
   gfx::ColorSpace color_space_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(VideoFrame);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_VIDEO_FRAME_H_