HostScanner: Add scanned hosts to NetworkStateHandler and NotificationPresenter.

HostScanner: Add scanned hosts to NetworkStateHandler and NotificationPresenter.
BUG=672263
Review-Url: https://codereview.chromium.org/2781263004
Cr-Commit-Position: refs/heads/master@{#462745}
Committed: https://chromium.googlesource.com/chromium/src/+/5a918a3454582514556a66d18bdf402e4488381e

[Ryan Hansberry, 2017-04-06 22:05:43]

Description was changed from

==========
Tether: Add scanned hosts to NetworkStateHandler.

BUG=672263
==========

to

==========
HostScanner: Add scanned hosts to NetworkStateHandler and NotificationPresenter.
BUG=672263
==========

[Ryan Hansberry, 2017-04-06 22:05:43]

hansberry@chromium.org changed reviewers:
+ khorimoto@chromium.org

[Kyle Horimoto, 2017-04-07 01:08:08]

lgtm

https://codereview.chromium.org/2781263004/diff/40001/chromeos/components/tet...
File chromeos/components/tether/host_scanner.cc (right):

https://codereview.chromium.org/2781263004/diff/40001/chromeos/components/tet...
chromeos/components/tether/host_scanner.cc:69: if
(scanned_device_list_so_far.size() == 1) {
nit: Do the UI stuff after the networks have been added instead of before.

https://codereview.chromium.org/2781263004/diff/40001/chromeos/components/tet...
chromeos/components/tether/host_scanner.cc:76: // TODO (hansberry): Clear out
old scanned hosts from NetworkStateHandler.
You'll also need a TODO for adding the device information (battery, reception,
etc).

https://codereview.chromium.org/2781263004/diff/40001/chromeos/components/tet...
File chromeos/components/tether/host_scanner_unittest.cc (right):

https://codereview.chromium.org/2781263004/diff/40001/chromeos/components/tet...
chromeos/components/tether/host_scanner_unittest.cc:196: for (auto
scanned_device_info : scanned_device_infos_so_far_) {
auto&

[Ryan Hansberry, 2017-04-07 01:25:05]

https://codereview.chromium.org/2781263004/diff/40001/chromeos/components/tet...
File chromeos/components/tether/host_scanner.cc (right):

https://codereview.chromium.org/2781263004/diff/40001/chromeos/components/tet...
chromeos/components/tether/host_scanner.cc:69: if
(scanned_device_list_so_far.size() == 1) {
On 2017/04/07 01:08:07, Kyle Horimoto wrote:
> nit: Do the UI stuff after the networks have been added instead of before.

Done.

https://codereview.chromium.org/2781263004/diff/40001/chromeos/components/tet...
chromeos/components/tether/host_scanner.cc:76: // TODO (hansberry): Clear out
old scanned hosts from NetworkStateHandler.
On 2017/04/07 01:08:08, Kyle Horimoto wrote:
> You'll also need a TODO for adding the device information (battery, reception,
> etc).

Done.

https://codereview.chromium.org/2781263004/diff/40001/chromeos/components/tet...
File chromeos/components/tether/host_scanner_unittest.cc (right):

https://codereview.chromium.org/2781263004/diff/40001/chromeos/components/tet...
chromeos/components/tether/host_scanner_unittest.cc:196: for (auto
scanned_device_info : scanned_device_infos_so_far_) {
On 2017/04/07 01:08:08, Kyle Horimoto wrote:
> auto&

Done.

[Ryan Hansberry, 2017-04-07 01:25:17]

The CQ bit was checked by hansberry@chromium.org

[Ryan Hansberry, 2017-04-07 01:25:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
khorimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2781263004/#ps60001
(title: "Address nits.")

[commit-bot: I haz the power, 2017-04-07 01:25:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 04:38:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491528317865150,
"parent_rev": "b1b017627acf79bdb62b1fa273d45e87fed29b5b", "commit_rev":
"5a918a3454582514556a66d18bdf402e4488381e"}

[commit-bot: I haz the power, 2017-04-07 04:39:45]

Description was changed from

==========
HostScanner: Add scanned hosts to NetworkStateHandler and NotificationPresenter.
BUG=672263
==========

to

==========
HostScanner: Add scanned hosts to NetworkStateHandler and NotificationPresenter.
BUG=672263

Review-Url: https://codereview.chromium.org/2781263004
Cr-Commit-Position: refs/heads/master@{#462745}
Committed:
https://chromium.googlesource.com/chromium/src/+/5a918a3454582514556a66d18bdf...
==========

[commit-bot: I haz the power, 2017-04-07 04:39:46]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5a918a3454582514556a66d18bdf...