Some C++11 cleanup of history types.

Some C++11 cleanup of history types.

History has a lot of vectors of structs that include things like URLs and strings that could benefit from move constructors. This implements move constructors on such classes in history_types.h.

Moves initialization of many values from explicit constructor initializer lists to the class definition for clarity and de-duplication. For URLRow this allowed removing the Initialize() helper function.

Some structs were using implicitly defined copy and assignment operators. These are defined now so they can be out-of-line for code bloat reasons.

An unused constructor on URLResult is removed.

Out-of-date references to dirty bits in comments in URLRow are removed. These dirty bits no longer exist.

Friend declarations in URLRow (these were related to handling of the aforementioned dirty bits) were removed and two places depending on these friend declarations were changed to use set_*() functions instead. A set_url() function was added which was the only missing setter.

Review-Url: https://codereview.chromium.org/2781263002
Cr-Commit-Position: refs/heads/master@{#461159}
Committed: https://chromium.googlesource.com/chromium/src/+/57694b362cc73fb681e98a5af85990261a9a2a88

[brettw, 2017-03-30 05:20:31]

Description was changed from

==========
Some C++11 cleanup of history types.

History has a lot of vectors of structs that include things like URLs and
strings that could benefit from move constructors. This implements move
constructors on such classes in history_types.h.

Moves initialization of many values from explicit constructor initializer lists
to the class definition for clarity and de-duplication. For URLRow this allowed
removing the Initialize() helper function.

Some structs were using implicitly defined copy and assignment operators. These
are defined now so they can be out-of-line for code bloat reasons.
==========

to

==========
Some C++11 cleanup of history types.

History has a lot of vectors of structs that include things like URLs and
strings that could benefit from move constructors. This implements move
constructors on such classes in history_types.h.

Moves initialization of many values from explicit constructor initializer lists
to the class definition for clarity and de-duplication. For URLRow this allowed
removing the Initialize() helper function.

Some structs were using implicitly defined copy and assignment operators. These
are defined now so they can be out-of-line for code bloat reasons.

An unused constructor on URLResult is removed.
==========

[brettw, 2017-03-30 05:21:25]

.

[brettw, 2017-03-30 05:21:58]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 05:22:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 05:30:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 05:30:38]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[brettw, 2017-03-30 16:33:35]

Fix

[brettw, 2017-03-30 16:33:35]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 16:33:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2017-03-30 16:45:29]

brettw@chromium.org changed reviewers:
+ gangwu@chromium.org

[commit-bot: I haz the power, 2017-03-30 16:57:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 16:57:35]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[brettw, 2017-03-30 19:51:42]

Description was changed from

==========
Some C++11 cleanup of history types.

History has a lot of vectors of structs that include things like URLs and
strings that could benefit from move constructors. This implements move
constructors on such classes in history_types.h.

Moves initialization of many values from explicit constructor initializer lists
to the class definition for clarity and de-duplication. For URLRow this allowed
removing the Initialize() helper function.

Some structs were using implicitly defined copy and assignment operators. These
are defined now so they can be out-of-line for code bloat reasons.

An unused constructor on URLResult is removed.
==========

to

==========
Some C++11 cleanup of history types.

History has a lot of vectors of structs that include things like URLs and
strings that could benefit from move constructors. This implements move
constructors on such classes in history_types.h.

Moves initialization of many values from explicit constructor initializer lists
to the class definition for clarity and de-duplication. For URLRow this allowed
removing the Initialize() helper function.

Some structs were using implicitly defined copy and assignment operators. These
are defined now so they can be out-of-line for code bloat reasons.

An unused constructor on URLResult is removed.

Out-of-date references to dirty bits in comments in URLRow are removed. These
dirty bits no longer exist.

Friend declarations in URLRow (these were related to handling of the
aforementioned dirty bits) were removed and two places depending on these friend
declarations were changed to use set_*() functions instead. A set_url() function
was added which was the only missing setter.
==========

[brettw, 2017-03-30 19:52:18]

Fix Android

[brettw, 2017-03-30 19:52:18]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 19:53:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 21:01:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 21:01:50]

Dry run: This issue passed the CQ dry run.

[Gang Wu, 2017-03-31 17:12:12]

lgtm

[brettw, 2017-03-31 17:12:46]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-03-31 17:13:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 17:23:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490980366635670,
"parent_rev": "6848185cfa70defaf604799578d35f238fe1c273", "commit_rev":
"57694b362cc73fb681e98a5af85990261a9a2a88"}

[commit-bot: I haz the power, 2017-03-31 17:24:40]

Description was changed from

==========
Some C++11 cleanup of history types.

History has a lot of vectors of structs that include things like URLs and
strings that could benefit from move constructors. This implements move
constructors on such classes in history_types.h.

Moves initialization of many values from explicit constructor initializer lists
to the class definition for clarity and de-duplication. For URLRow this allowed
removing the Initialize() helper function.

Some structs were using implicitly defined copy and assignment operators. These
are defined now so they can be out-of-line for code bloat reasons.

An unused constructor on URLResult is removed.

Out-of-date references to dirty bits in comments in URLRow are removed. These
dirty bits no longer exist.

Friend declarations in URLRow (these were related to handling of the
aforementioned dirty bits) were removed and two places depending on these friend
declarations were changed to use set_*() functions instead. A set_url() function
was added which was the only missing setter.
==========

to

==========
Some C++11 cleanup of history types.

History has a lot of vectors of structs that include things like URLs and
strings that could benefit from move constructors. This implements move
constructors on such classes in history_types.h.

Moves initialization of many values from explicit constructor initializer lists
to the class definition for clarity and de-duplication. For URLRow this allowed
removing the Initialize() helper function.

Some structs were using implicitly defined copy and assignment operators. These
are defined now so they can be out-of-line for code bloat reasons.

An unused constructor on URLResult is removed.

Out-of-date references to dirty bits in comments in URLRow are removed. These
dirty bits no longer exist.

Friend declarations in URLRow (these were related to handling of the
aforementioned dirty bits) were removed and two places depending on these friend
declarations were changed to use set_*() functions instead. A set_url() function
was added which was the only missing setter.

Review-Url: https://codereview.chromium.org/2781263002
Cr-Commit-Position: refs/heads/master@{#461159}
Committed:
https://chromium.googlesource.com/chromium/src/+/57694b362cc73fb681e98a5af859...
==========

[commit-bot: I haz the power, 2017-03-31 17:24:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/57694b362cc73fb681e98a5af859...