Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2781213002: Remove useless SpellChecker::clearMisspellingsForMovingParagraphs() (Closed)

Created:
3 years, 8 months ago by Xiaocheng
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove useless SpellChecker::clearMisspellingsForMovingParagraphs() The above mentioned functions removes markers from nodes that will be removed, which is meaningless because node removal removes marker eventually. Hence, this patch removes this function. BUG=700217 TEST=n/a; no behavior change Review-Url: https://codereview.chromium.org/2781213002 Cr-Commit-Position: refs/heads/master@{#460652} Committed: https://chromium.googlesource.com/chromium/src/+/9dede133389c377cc53eff4fd50d6a220318d882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
3 years, 8 months ago (2017-03-30 01:25:04 UTC) #4
yosin_UTC9
lgtm Good catch! (^_^)b
3 years, 8 months ago (2017-03-30 02:10:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781213002/1
3 years, 8 months ago (2017-03-30 02:11:15 UTC) #8
Xiaocheng
On 2017/03/30 at 02:10:51, yosin wrote: > lgtm > > Good catch! (^_^)b Yeah, your ...
3 years, 8 months ago (2017-03-30 02:21:54 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 03:53:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9dede133389c377cc53eff4fd50d...

Powered by Google App Engine
This is Rietveld 408576698