Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2781183002: Remove image_decode_tasks_enabled flag. (Closed)

Created:
3 years, 8 months ago by vmpstr
Modified:
3 years, 7 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, Ian Vollick
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove image_decode_tasks_enabled flag. This flag should be on by default in all non-test cases, so this patch removes the flag altogether. BUG=696864 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2781183002 Cr-Commit-Position: refs/heads/master@{#467725} Committed: https://chromium.googlesource.com/chromium/src/+/5cff918de35f1a3379d8fce7984eef770e1e2d44

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : update #

Patch Set 4 : rebase #

Patch Set 5 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -84 lines) Patch
M cc/layers/picture_layer.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/layers/recording_source.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/layers/recording_source.cc View 3 chunks +1 line, -8 lines 0 comments Download
M cc/layers/recording_source_unittest.cc View 1 5 chunks +0 lines, -26 lines 0 comments Download
M cc/raster/raster_source_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M cc/test/fake_recording_source.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 1 2 3 4 3 chunks +0 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_checkerimaging.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.h View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/gpu/compositor_dependencies.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 2 chunks +0 lines, -8 lines 0 comments Download
M content/test/fake_compositor_dependencies.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/fake_compositor_dependencies.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 41 (29 generated)
vmpstr
Please take a look.
3 years, 8 months ago (2017-04-17 23:32:33 UTC) #20
enne (OOO)
lgtm
3 years, 8 months ago (2017-04-17 23:36:01 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781183002/60001
3 years, 8 months ago (2017-04-25 17:43:07 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/419845)
3 years, 8 months ago (2017-04-25 17:49:45 UTC) #26
vmpstr
+creis for content +danakj for ui Please take a look.
3 years, 8 months ago (2017-04-25 22:10:14 UTC) #28
Charlie Reis
Thanks for the cleanup! content/ LGTM.
3 years, 8 months ago (2017-04-25 22:47:31 UTC) #29
vmpstr
ping danakj@ for ui/compositor.
3 years, 8 months ago (2017-04-26 17:41:27 UTC) #30
danakj
ui LGTM
3 years, 8 months ago (2017-04-26 22:43:59 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781183002/80001
3 years, 8 months ago (2017-04-26 22:49:00 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/280612)
3 years, 8 months ago (2017-04-27 01:46:32 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781183002/80001
3 years, 7 months ago (2017-04-27 16:18:22 UTC) #38
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 17:48:50 UTC) #41
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5cff918de35f1a3379d8fce7984e...

Powered by Google App Engine
This is Rietveld 408576698