Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2781103002: [cc] Forward BeginFrameAcks through RWHVAndroid / DFHAndroid. (Closed)

Created:
3 years, 8 months ago by Eric Seckler
Modified:
3 years, 8 months ago
Reviewers:
boliu
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su, Sami, brianderson, Fady Samuel, enne (OOO)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[cc] Forward BeginFrameAcks through RWHVAndroid / DFHAndroid. Passes on BeginFrameAcks from RenderWidgetHostViewAndroid through DelegatedFrameHostAndroid to its CompositorFrameSinkSupport. This is work towards unified BeginFrame acknowledgments, see: Tracking bug: https://crbug.com/697086 Design doc: http://bit.ly/beginframeacks BUG=697086, 646774 Review-Url: https://codereview.chromium.org/2781103002 Cr-Commit-Position: refs/heads/master@{#460750} Committed: https://chromium.googlesource.com/chromium/src/+/e4201c2d7ffca39470fa1a69febc2e9c92f10def

Patch Set 1 #

Total comments: 2

Patch Set 2 : add AcknowledgeBeginFrame helper #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.h View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 5 chunks +37 lines, -2 lines 0 comments Download
M ui/android/delegated_frame_host_android.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
Eric Seckler
Bo, PTAL :)
3 years, 8 months ago (2017-03-29 14:04:45 UTC) #2
boliu
https://codereview.chromium.org/2781103002/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc (right): https://codereview.chromium.org/2781103002/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc#newcode1181 content/browser/renderer_host/render_widget_host_view_android.cc:1181: latest_confirmed_begin_frame_source_id_ = ack.source_id; this is an exact duplicate of ...
3 years, 8 months ago (2017-03-29 16:04:00 UTC) #8
Eric Seckler
https://codereview.chromium.org/2781103002/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc (right): https://codereview.chromium.org/2781103002/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc#newcode1181 content/browser/renderer_host/render_widget_host_view_android.cc:1181: latest_confirmed_begin_frame_source_id_ = ack.source_id; On 2017/03/29 16:03:59, boliu wrote: > ...
3 years, 8 months ago (2017-03-30 10:59:25 UTC) #9
boliu
lgtm
3 years, 8 months ago (2017-03-30 14:19:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781103002/40001
3 years, 8 months ago (2017-03-30 14:22:45 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 14:27:46 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e4201c2d7ffca39470fa1a69febc...

Powered by Google App Engine
This is Rietveld 408576698