Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2781093004: Disable BottomSheetTest on pre-Lollipop MR1 (Closed)

Created:
3 years, 8 months ago by kraush
Modified:
3 years, 8 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable BottomSheetTest on pre-Lollipop MR1 BottomSheetTests have a hard dependency on RecyclerView, which is a class that was added in SDK level 22 (Lollipop MR 1). This change disables BottomSheetTests on all API levels which do not have RecyclerView. BUG=None Review-Url: https://codereview.chromium.org/2781093004 Cr-Commit-Position: refs/heads/master@{#460554} Committed: https://chromium.googlesource.com/chromium/src/+/7038439b2c151c9dd0fcd1de0330f2785d11d09a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/test/android/javatests/src/org/chromium/chrome/test/BottomSheetTestCaseBase.java View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kraush
Hi nyquist, Can you take a look at this change to disable BottomSheetTests on devices ...
3 years, 8 months ago (2017-03-29 19:58:21 UTC) #2
nyquist
lgtm, but is there a bug for this? If not, could you add BUG=None to ...
3 years, 8 months ago (2017-03-29 20:47:38 UTC) #3
kraush
On 2017/03/29 20:47:38, nyquist wrote: > lgtm, but is there a bug for this? > ...
3 years, 8 months ago (2017-03-29 20:55:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781093004/1
3 years, 8 months ago (2017-03-29 20:57:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7038439b2c151c9dd0fcd1de0330f2785d11d09a
3 years, 8 months ago (2017-03-29 22:26:40 UTC) #10
Theresa
3 years, 7 months ago (2017-05-10 21:14:05 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2871173003/ by twellington@chromium.org.

The reason for reverting is: android.support.v7.widget.RecyclerView is a support
library class. It can be used regardless of the Android version..

Powered by Google App Engine
This is Rietveld 408576698