Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2781083004:
[subresource_filter] Fix compile in GOOGLE_CHROME_BUILD (Closed)
|
Created:
3 years, 8 months ago by Charlie Harrison Modified:
3 years, 8 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, subresource-filter-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[subresource_filter] Fix compile in GOOGLE_CHROME_BUILD
TBR=melandory@chromium.org
BUG=706543
Review-Url: https://codereview.chromium.org/2781083004
Cr-Commit-Position: refs/heads/master@{#460560}
Committed: https://chromium.googlesource.com/chromium/src/+/ee2be17a3a10b3c6c556cf43061e0a9d1f239b18
Patch Set 1 #
Messages
Total messages: 19 (14 generated)
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Description was changed from ========== [subresource_filter] Fix compile in GOOGLE_CHROME_BUILD BUG=706543 ========== to ========== [subresource_filter] Fix compile in GOOGLE_CHROME_BUILD TBR=melandory@chromium.org BUG=706543 ==========
csharrison@chromium.org changed reviewers: + melandory@chromium.org
melandory: please TBR
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by csharrison@chromium.org
The CQ bit was checked by csharrison@chromium.org
The CQ bit was unchecked by csharrison@chromium.org
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
csharrison@chromium.org changed reviewers: + xunjieli@chromium.org
Helen, would you please sanity check? I don't like submitting CLs without any additional eyes.
On 2017/03/29 21:11:32, Charlie Harrison wrote: > Helen, would you please sanity check? I don't like submitting CLs without any > additional eyes. lgtm. Took me a while to figure out if there are more function overloads for NavigateAndExpectActivation(). I see why overloading functions is discouraged (https://google.github.io/styleguide/cppguide.html#Function_Overloading)00000 :)
The CQ bit was unchecked by csharrison@chromium.org
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490822375611920, "parent_rev":
"4e7d0d74049c9a5fc567355ea59510a323b2538a", "commit_rev":
"ee2be17a3a10b3c6c556cf43061e0a9d1f239b18"}
Message was sent while issue was closed.
Description was changed from ========== [subresource_filter] Fix compile in GOOGLE_CHROME_BUILD TBR=melandory@chromium.org BUG=706543 ========== to ========== [subresource_filter] Fix compile in GOOGLE_CHROME_BUILD TBR=melandory@chromium.org BUG=706543 Review-Url: https://codereview.chromium.org/2781083004 Cr-Commit-Position: refs/heads/master@{#460560} Committed: https://chromium.googlesource.com/chromium/src/+/ee2be17a3a10b3c6c556cf43061e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ee2be17a3a10b3c6c556cf43061e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
