Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2781073002:
Use the old back button on Terms of Service. (Closed)
|
Created:
3 years, 8 months ago by lpromero Modified:
3 years, 8 months ago CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse the old back button on Terms of Service.
https://drive.google.com/file/d/0Bwef-6NjeDzAdWxxRkM2dGQ0dEE
BUG=678953
R=kkhorimoto@chromium.org
Review-Url: https://codereview.chromium.org/2781073002
Cr-Commit-Position: refs/heads/master@{#460759}
Committed: https://chromium.googlesource.com/chromium/src/+/7cc34e89e276ddcb3dad93f8128d424a19a6cffe
Patch Set 1 #Patch Set 2 : Fix tests #Patch Set 3 : Fix gn deps #
Total comments: 2
Patch Set 4 : Feedback #
Messages
Total messages: 29 (22 generated)
The CQ bit was checked by lpromero@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use the old back button on Terms of Service. BUG=678953 R=pschaffner@chromium.org ========== to ========== Use the old back button on Terms of Service. BUG=678953 R=kkhorimoto@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by lpromero@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lpromero@chromium.org changed reviewers: + kkhorimoto@chromium.org
Description was changed from ========== Use the old back button on Terms of Service. BUG=678953 R=kkhorimoto@chromium.org ========== to ========== Use the old back button on Terms of Service. https://drive.google.com/file/d/0Bwef-6NjeDzAdWxxRkM2dGQ0dEE BUG=678953 R=kkhorimoto@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by lpromero@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with nit. https://codereview.chromium.org/2781073002/diff/40001/ios/chrome/browser/ui/f... File ios/chrome/browser/ui/first_run/static_file_view_controller.mm (right): https://codereview.chromium.org/2781073002/diff/40001/ios/chrome/browser/ui/f... ios/chrome/browser/ui/first_run/static_file_view_controller.mm:33: Can we add |-back| to this class's private interface?
The CQ bit was checked by lpromero@chromium.org to run a CQ dry run
The CQ bit was checked by lpromero@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kkhorimoto@chromium.org Link to the patchset: https://codereview.chromium.org/2781073002/#ps60001 (title: "Feedback")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thank you! https://codereview.chromium.org/2781073002/diff/40001/ios/chrome/browser/ui/f... File ios/chrome/browser/ui/first_run/static_file_view_controller.mm (right): https://codereview.chromium.org/2781073002/diff/40001/ios/chrome/browser/ui/f... ios/chrome/browser/ui/first_run/static_file_view_controller.mm:33: On 2017/03/29 20:48:18, kkhorimoto_ wrote: > Can we add |-back| to this class's private interface? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by lpromero@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490884685418070,
"parent_rev": "60f6a1eeebb81e29c0a6b351ed2e3c432787fbc4", "commit_rev":
"7cc34e89e276ddcb3dad93f8128d424a19a6cffe"}
Message was sent while issue was closed.
Description was changed from ========== Use the old back button on Terms of Service. https://drive.google.com/file/d/0Bwef-6NjeDzAdWxxRkM2dGQ0dEE BUG=678953 R=kkhorimoto@chromium.org ========== to ========== Use the old back button on Terms of Service. https://drive.google.com/file/d/0Bwef-6NjeDzAdWxxRkM2dGQ0dEE BUG=678953 R=kkhorimoto@chromium.org Review-Url: https://codereview.chromium.org/2781073002 Cr-Commit-Position: refs/heads/master@{#460759} Committed: https://chromium.googlesource.com/chromium/src/+/7cc34e89e276ddcb3dad93f8128d... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/7cc34e89e276ddcb3dad93f8128d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
