Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2781063002: Fix GN bootstrap (Closed)

Created:
3 years, 8 months ago by Paweł Hajdan Jr.
Modified:
3 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN bootstrap BUG=none R=brettw@chromium.org Review-Url: https://codereview.chromium.org/2781063002 . Cr-Commit-Position: refs/heads/master@{#460433} Committed: https://chromium.googlesource.com/chromium/src/+/e2b71b92f726eb998e8176da1be881d2755dd451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paweł Hajdan Jr.
3 years, 8 months ago (2017-03-29 10:31:34 UTC) #2
brettw
lgtm
3 years, 8 months ago (2017-03-29 17:11:47 UTC) #3
Paweł Hajdan Jr.
3 years, 8 months ago (2017-03-29 17:15:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e2b71b92f726eb998e8176da1be881d2755dd451 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698