Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2780993003: Remove redundant WebLocalFrame* parameter from didCreateDataSource (Closed)
Patch Set: Rebased onto asserts patch Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | third_party/WebKit/Source/web/LocalFrameClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 679773f82aca83ced3397903a82c2e4dd7c899e6..a1df88dd227e830c8fb631501eb3b10a5d19e538 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3384,10 +3384,7 @@ void RenderFrameImpl::willSubmitForm(const blink::WebFormElement& form) {
observer.WillSubmitForm(form);
}
-void RenderFrameImpl::didCreateDataSource(blink::WebLocalFrame* frame,
- blink::WebDataSource* datasource) {
- DCHECK(!frame_ || frame_ == frame);
jochen (gone - plz use gerrit) 2017/03/30 11:43:43 this doesn't look like it's good enough to proof r
-
+void RenderFrameImpl::didCreateDataSource(blink::WebDataSource* datasource) {
bool content_initiated = !pending_navigation_params_.get();
// Make sure any previous redirect URLs end up in our new data source.
@@ -3479,7 +3476,7 @@ void RenderFrameImpl::didCreateDataSource(blink::WebLocalFrame* frame,
datasource->setServiceWorkerNetworkProvider(
ServiceWorkerNetworkProvider::CreateForNavigation(
- routing_id_, navigation_state->request_params(), frame,
+ routing_id_, navigation_state->request_params(), frame_,
content_initiated));
}
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | third_party/WebKit/Source/web/LocalFrameClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698