Reduce overbuilding due to about_credits.html

Reduce overbuilding due to about_credits.html

Efficiently determining when to build about_credits.html is hard.
Currently it is marked as dirty anytime the root .ninja file is
modified, so after every "gn gen" or modification of any BUILD.gn file
it gets rewritten, triggering 106 steps on Windows, 58 steps on Linux.

This change just makes the script smart enough to not write the file if
its contents have not changed. Thus, 105 of the 106 steps on Windows,
including linking of chrome.exe, can be skipped.

In addition to slightly improving build times this change makes it more
obvious what is going on. It makes it (fairly) clear that
about_credits.html is being regenerated but has not actually changed.

R=agrieve@chromium.org
BUG=692601
Review-Url: https://codereview.chromium.org/2780983004
Cr-Commit-Position: refs/heads/master@{#460807}
Committed: https://chromium.googlesource.com/chromium/src/+/b5acc4c7976d45ace977c14019593c9413d0841d

[brucedawson, 2017-03-29 22:08:21]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 22:09:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-03-29 22:16:28]

Description was changed from

==========
Reduce overbuilding due to about_credits.html

Efficiently determining when to build about_credits.html is hard.
Currently it is marked as dirty anytime the root .ninja file is
modified, so after every "gn gen" or modification of any BUILD.gn file
it gets rewritten, triggering 106 steps on Windows, 58 steps on Linux.

This change just makes the script smart enough to not write the file if
its contents have not changed. Thus, 105 of the 106 steps, including
linking of chrome.exe, can be skipped.

R=agrieve@chromium.org
BUG=692601
==========

to

==========
Reduce overbuilding due to about_credits.html

Efficiently determining when to build about_credits.html is hard.
Currently it is marked as dirty anytime the root .ninja file is
modified, so after every "gn gen" or modification of any BUILD.gn file
it gets rewritten, triggering 106 steps on Windows, 58 steps on Linux.

This change just makes the script smart enough to not write the file if
its contents have not changed. Thus, 105 of the 106 steps on Windows,
including linking of chrome.exe, can be skipped.

R=agrieve@chromium.org
BUG=692601
==========

[brucedawson, 2017-03-29 22:47:19]

Description was changed from

==========
Reduce overbuilding due to about_credits.html

Efficiently determining when to build about_credits.html is hard.
Currently it is marked as dirty anytime the root .ninja file is
modified, so after every "gn gen" or modification of any BUILD.gn file
it gets rewritten, triggering 106 steps on Windows, 58 steps on Linux.

This change just makes the script smart enough to not write the file if
its contents have not changed. Thus, 105 of the 106 steps on Windows,
including linking of chrome.exe, can be skipped.

R=agrieve@chromium.org
BUG=692601
==========

to

==========
Reduce overbuilding due to about_credits.html

Efficiently determining when to build about_credits.html is hard.
Currently it is marked as dirty anytime the root .ninja file is
modified, so after every "gn gen" or modification of any BUILD.gn file
it gets rewritten, triggering 106 steps on Windows, 58 steps on Linux.

This change just makes the script smart enough to not write the file if
its contents have not changed. Thus, 105 of the 106 steps on Windows,
including linking of chrome.exe, can be skipped.

In addition to slightly improving build times this change makes it more
obvious what is going on. It makes it (fairly) clear that
about_credits.html is being regenerated but has not actually changed.

R=agrieve@chromium.org
BUG=692601
==========

[brucedawson, 2017-03-29 23:45:58]

PTAL - description should be self-explanatory

[agrieve, 2017-03-29 23:50:06]

On 2017/03/29 23:45:58, brucedawson wrote:
> PTAL - description should be self-explanatory

lgtm

[brucedawson, 2017-03-29 23:51:03]

The CQ bit was unchecked by brucedawson@chromium.org

[brucedawson, 2017-03-29 23:51:09]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-03-29 23:51:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 00:05:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 00:05:43]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brucedawson, 2017-03-30 00:09:07]

brucedawson@chromium.org changed reviewers:
+ dpranke@chromium.org

[brucedawson, 2017-03-30 00:09:08]

Need owner approval - dpranke@, PTAL.

[Dirk Pranke, 2017-03-30 03:26:51]

lgtm

[brucedawson, 2017-03-30 17:01:48]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-03-30 17:02:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 17:17:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490893308508250, "parent_rev":
"76a92450937342766d630d01a28402e06e2f0622", "commit_rev":
"b5acc4c7976d45ace977c14019593c9413d0841d"}

[commit-bot: I haz the power, 2017-03-30 17:17:47]

Description was changed from

==========
Reduce overbuilding due to about_credits.html

Efficiently determining when to build about_credits.html is hard.
Currently it is marked as dirty anytime the root .ninja file is
modified, so after every "gn gen" or modification of any BUILD.gn file
it gets rewritten, triggering 106 steps on Windows, 58 steps on Linux.

This change just makes the script smart enough to not write the file if
its contents have not changed. Thus, 105 of the 106 steps on Windows,
including linking of chrome.exe, can be skipped.

In addition to slightly improving build times this change makes it more
obvious what is going on. It makes it (fairly) clear that
about_credits.html is being regenerated but has not actually changed.

R=agrieve@chromium.org
BUG=692601
==========

to

==========
Reduce overbuilding due to about_credits.html

Efficiently determining when to build about_credits.html is hard.
Currently it is marked as dirty anytime the root .ninja file is
modified, so after every "gn gen" or modification of any BUILD.gn file
it gets rewritten, triggering 106 steps on Windows, 58 steps on Linux.

This change just makes the script smart enough to not write the file if
its contents have not changed. Thus, 105 of the 106 steps on Windows,
including linking of chrome.exe, can be skipped.

In addition to slightly improving build times this change makes it more
obvious what is going on. It makes it (fairly) clear that
about_credits.html is being regenerated but has not actually changed.

R=agrieve@chromium.org
BUG=692601

Review-Url: https://codereview.chromium.org/2780983004
Cr-Commit-Position: refs/heads/master@{#460807}
Committed:
https://chromium.googlesource.com/chromium/src/+/b5acc4c7976d45ace977c1401959...
==========

[commit-bot: I haz the power, 2017-03-30 17:17:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b5acc4c7976d45ace977c1401959...