Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2780983003: Reland: Avoid calling strlen() where possible in base/trace_config (Closed)

Created:
3 years, 8 months ago by Andrey Kraynov
Modified:
3 years, 8 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, oshima+watch_chromium.org, yusukes+watch_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, tracing+reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Avoid calling strlen() where possible in base/trace_config Fix for crbug.com/706416 was landed and this patch should work fine. The main target of this CL is to avoid calling strlen() where possible. It can happen if a raw |char*| literal or result of |c_str()| function is used to construct a StringPiece or std::string objects. In addition, StringPiece API like SplitStringPiece was used to avoid unnecessary string copying and allocations. BUG=679479 TBR=primiano@chromium.org,yusukes@chromium.org Review-Url: https://codereview.chromium.org/2780983003 Cr-Commit-Position: refs/heads/master@{#460720} Committed: https://chromium.googlesource.com/chromium/src/+/5e8d28b598fa533bd3c0503e59e037d63913fbde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -36 lines) Patch
M base/trace_event/trace_config.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_config.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_config_category_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_config_category_filter.cc View 5 chunks +17 lines, -18 lines 0 comments Download
M base/trace_event/trace_event_etw_export_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_etw_export_win.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Andrey Kraynov
Hi! This is a reland of my CL https://codereview.chromium.org/2777203004/ It was landed and then reverted ...
3 years, 8 months ago (2017-03-29 21:30:00 UTC) #1
Yusuke Sato
arc/ lgtm
3 years, 8 months ago (2017-03-30 00:53:46 UTC) #2
Primiano Tucci (use gerrit)
lgtm
3 years, 8 months ago (2017-03-30 09:13:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780983003/1
3 years, 8 months ago (2017-03-30 09:13:25 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 11:22:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e8d28b598fa533bd3c0503e59e0...

Powered by Google App Engine
This is Rietveld 408576698