Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2780933003: DevTools: support UISourceCode rename in automapping (Closed)

Created:
3 years, 8 months ago by lushnikov
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: support UISourceCode rename in automapping Support file renames in Automapping. As a drive-by, this patch promisifies UISourceCode.rename() and InspectorTest.AutomappintTest.waitForAutomappintStabilized() methods. This comes handy with async/await. R=dgozman BUG=none Review-Url: https://codereview.chromium.org/2780933003 Cr-Commit-Position: refs/heads/master@{#460913} Committed: https://chromium.googlesource.com/chromium/src/+/94722f6e997ae353b37bc62ef22419ea0cfff877

Patch Set 1 #

Patch Set 2 : add a test #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -34 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-absolute-paths.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-dynamic-uisourcecodes.html View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-git-folders.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-rename-files.html View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-rename-files-expected.txt View 1 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-sane.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-sourcemap.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-sourcemap-nameclash.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-test.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/file-system-project.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html View 9 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js View 1 2 2 chunks +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js View 4 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/Workspace.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
lushnikov
please, take a look
3 years, 8 months ago (2017-03-29 01:22:23 UTC) #1
dgozman
Please add a test. lgtm
3 years, 8 months ago (2017-03-29 21:00:02 UTC) #6
lushnikov
Added test, thanks
3 years, 8 months ago (2017-03-29 21:03:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780933003/20001
3 years, 8 months ago (2017-03-29 21:04:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/411132)
3 years, 8 months ago (2017-03-29 22:54:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780933003/40001
3 years, 8 months ago (2017-03-30 20:52:34 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 22:59:13 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/94722f6e997ae353b37bc62ef224...

Powered by Google App Engine
This is Rietveld 408576698