Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2780923003: Revert of Change minimum length of Aura overlay scrollbars. (Closed)

Created:
3 years, 8 months ago by bokan
Modified:
3 years, 8 months ago
Reviewers:
pdr., nasko, Evan Stade
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change minimum length of Aura overlay scrollbars. (patchset #9 id:160001 of https://codereview.chromium.org/2734483002/ ) Reason for revert: Unit test failing on Android: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/62927 Original issue's description: > Change minimum length of Aura overlay scrollbars. > > It turns out Aura (and Android) overlay scrollbars weren't using the minimum > defined in NativeThemeAura. Instead, the minimum was set from > ScrollbarTheme::minimumThumbLength which just returns the thumb thickness. > > After adding an override for ScrollbarThemeOverlay which correctly uses the > value form NativeThemeAura, the only consumers of > ScrollbarTheme::minimumThumbLength are the mock classes so I moved the base > implementation into the Mock class and made the base pure virtual. > > BUG=678595 > > Review-Url: https://codereview.chromium.org/2734483002 > Cr-Commit-Position: refs/heads/master@{#460199} > Committed: https://chromium.googlesource.com/chromium/src/+/151a2db45f5fdbca8973988dd51d2bf6c86fbc8c TBR=estade@chromium.org,nasko@chromium.org,pdr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=678595 Review-Url: https://codereview.chromium.org/2780923003 Cr-Commit-Position: refs/heads/master@{#460224} Committed: https://chromium.googlesource.com/chromium/src/+/d04d3a25c0615e015c3d8cb603ccab0081e350df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -140 lines) Patch
M content/child/webthemeengine_impl_android.cc View 2 chunks +6 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp View 1 chunk +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.h View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollbarsTest.cpp View 2 chunks +0 lines, -73 lines 0 comments Download
M ui/native_theme/native_theme_aura.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
bokan
Created Revert of Change minimum length of Aura overlay scrollbars.
3 years, 8 months ago (2017-03-28 22:23:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780923003/1
3 years, 8 months ago (2017-03-28 22:23:51 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 22:25:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d04d3a25c0615e015c3d8cb603cc...

Powered by Google App Engine
This is Rietveld 408576698