Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2780913002:
Add some missing stdarg includes (Closed)
DescriptionAdd some missing stdarg includes
One of our internal Chromecast builds was failing due to undefined
va_list in wasm-result.h. I also searched for other files where va_list
was used without including stdarg.h and added it as necessary (since
include-what-you-use is a thing).
BUG=chromium:706443
Review-Url: https://codereview.chromium.org/2780913002
Cr-Commit-Position: refs/heads/master@{#44588}
Committed: https://chromium.googlesource.com/v8/v8/+/f7e76cded6699b6d89021d055e51d1f4e58f6cc5
Patch Set 1 #Patch Set 2 : ... #
Messages
Total messages: 28 (14 generated)
kmackay@chromium.org changed reviewers: + clemensh@google.com, jarin@chromium.org, jochen@chromium.org, ulan@chromium.org
how did you find that those are missing? Can you explain that in the CL description please? Is there a tracking bug that can be referenced?
Description was changed from ========== Add some missing stdarg includes BUG= ========== to ========== Add some missing stdarg includes One of our internal Chromecast builds was failing due to undefined va_list in wasm-result.h. I also searched for other files where va_list was used without including stdarg.h and added it as necessary (since include-what-you-use is a thing). BUG= ==========
On 2017/03/29 06:30:55, jochen wrote: > how did you find that those are missing? Can you explain that in the CL > description please? > > Is there a tracking bug that can be referenced? I updated the description. I don't have a tracking bug though.
cool, thx! could you please file a tracking bug, in case you need this merged or something. Also, please wrap the CL description at <= 80 cols, then we're good to go!
Description was changed from ========== Add some missing stdarg includes One of our internal Chromecast builds was failing due to undefined va_list in wasm-result.h. I also searched for other files where va_list was used without including stdarg.h and added it as necessary (since include-what-you-use is a thing). BUG= ========== to ========== Add some missing stdarg includes One of our internal Chromecast builds was failing due to undefined va_list in wasm-result.h. I also searched for other files where va_list was used without including stdarg.h and added it as necessary (since include-what-you-use is a thing). BUG=706443 ==========
On 2017/03/29 15:19:46, jochen wrote: > cool, thx! > > could you please file a tracking bug, in case you need this merged or something. > > Also, please wrap the CL description at <= 80 cols, then we're good to go! Done.
Description was changed from ========== Add some missing stdarg includes One of our internal Chromecast builds was failing due to undefined va_list in wasm-result.h. I also searched for other files where va_list was used without including stdarg.h and added it as necessary (since include-what-you-use is a thing). BUG=706443 ========== to ========== Add some missing stdarg includes One of our internal Chromecast builds was failing due to undefined va_list in wasm-result.h. I also searched for other files where va_list was used without including stdarg.h and added it as necessary (since include-what-you-use is a thing). BUG=chromium:706443 ==========
Description was changed from ========== Add some missing stdarg includes One of our internal Chromecast builds was failing due to undefined va_list in wasm-result.h. I also searched for other files where va_list was used without including stdarg.h and added it as necessary (since include-what-you-use is a thing). BUG=706443 ========== to ========== Add some missing stdarg includes One of our internal Chromecast builds was failing due to undefined va_list in wasm-result.h. I also searched for other files where va_list was used without including stdarg.h and added it as necessary (since include-what-you-use is a thing). BUG=chromium:706443 ==========
On 2017/03/29 at 16:44:34, kmackay wrote: > On 2017/03/29 15:19:46, jochen wrote: > > cool, thx! > > > > could you please file a tracking bug, in case you need this merged or something. > > > > Also, please wrap the CL description at <= 80 cols, then we're good to go! > > Done. In v8 you have to prefix chromium issues... I did that for you :) lgtm
The CQ bit was checked by kmackay@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/38004)
clemensh@chromium.org changed reviewers: + clemensh@chromium.org
lgtm
lgtm
The CQ bit was checked by kmackay@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/38102)
The CQ bit was checked by kmackay@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from clemensh@chromium.org, ulan@chromium.org, jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2780913002/#ps20001 (title: "...")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491929245624000,
"parent_rev": "dd1e2e849939e1728910cf293bb2651c98a12dba", "commit_rev":
"f7e76cded6699b6d89021d055e51d1f4e58f6cc5"}
Message was sent while issue was closed.
Description was changed from ========== Add some missing stdarg includes One of our internal Chromecast builds was failing due to undefined va_list in wasm-result.h. I also searched for other files where va_list was used without including stdarg.h and added it as necessary (since include-what-you-use is a thing). BUG=chromium:706443 ========== to ========== Add some missing stdarg includes One of our internal Chromecast builds was failing due to undefined va_list in wasm-result.h. I also searched for other files where va_list was used without including stdarg.h and added it as necessary (since include-what-you-use is a thing). BUG=chromium:706443 Review-Url: https://codereview.chromium.org/2780913002 Cr-Commit-Position: refs/heads/master@{#44588} Committed: https://chromium.googlesource.com/v8/v8/+/f7e76cded6699b6d89021d055e51d1f4e58... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/f7e76cded6699b6d89021d055e51d1f4e58... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
