Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2780903003: DevTools: [Workspaces] remove support for .devtools file (Closed)

Created:
3 years, 8 months ago by lushnikov
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Workspaces] remove support for .devtools file The .devtools file was an attempt to solve the Workspace mappings problem. It didn't really work and didn't get much traction. Today, it is no longer needed since Persistence2.0 solves the mappings problem. This patch is a pre-step before enabling Persistence 2.0 experiment by default. BUG=277885 R=dgozman Review-Url: https://codereview.chromium.org/2780903003 Cr-Commit-Position: refs/heads/master@{#465900} Committed: https://chromium.googlesource.com/chromium/src/+/bafdd183fcee7aa3354babad88f464e3b9810cd8

Patch Set 1 #

Patch Set 2 : kill .devtools #

Patch Set 3 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -361 lines) Patch
D third_party/WebKit/LayoutTests/http/tests/inspector/file-system-project-mapping.html View 1 2 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/file-system-project-mapping-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/file-system-mapping-expected.txt View 5 chunks +33 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/file-system-mapping-overrides.html View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/file-system-mapping-overrides-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/file-system-project.html View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/file-system-project-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/devtools/.devtools View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js View 1 2 5 chunks +7 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/editFileSystemView.css View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/FileSystemMapping.js View 11 chunks +10 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystem.js View 5 chunks +2 lines, -52 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
lushnikov
please, take a look
3 years, 8 months ago (2017-03-28 22:17:48 UTC) #1
dgozman
As discussed offline, let's wait with this.
3 years, 8 months ago (2017-03-28 22:32:31 UTC) #6
lushnikov
let's resurrect this!
3 years, 8 months ago (2017-04-17 23:42:07 UTC) #9
pfeldman
why? :)
3 years, 8 months ago (2017-04-17 23:49:09 UTC) #10
lushnikov
since we keep file mappings, let's at least simplify them!
3 years, 8 months ago (2017-04-18 00:17:54 UTC) #11
dgozman
lgtm
3 years, 8 months ago (2017-04-18 22:49:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780903003/20001
3 years, 8 months ago (2017-04-19 18:15:17 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/122767) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 8 months ago (2017-04-19 18:20:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780903003/40001
3 years, 8 months ago (2017-04-20 03:18:13 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 04:54:15 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bafdd183fcee7aa3354babad88f4...

Powered by Google App Engine
This is Rietveld 408576698