Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8132)

Unified Diff: chrome/browser/site_per_process_interactive_browsertest.cc

Issue 2780883003: OOPIF: Enable TabAndMouseFocusNavigation. (Closed)
Patch Set: Exclude ozone since the mouse events don't seem to happen. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/site_per_process_interactive_browsertest.cc
diff --git a/chrome/browser/site_per_process_interactive_browsertest.cc b/chrome/browser/site_per_process_interactive_browsertest.cc
index eb7b3a26c4a95be515748c9899f08e72b60173aa..a3963605a420435bb03f5c098804d10430c7849a 100644
--- a/chrome/browser/site_per_process_interactive_browsertest.cc
+++ b/chrome/browser/site_per_process_interactive_browsertest.cc
@@ -302,11 +302,11 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest,
EXPECT_EQ(main_frame, web_contents->GetFocusedFrame());
}
-// TODO(https://crbug.com/702330): Enable this test.
+#if (defined(OS_LINUX) && !defined(USE_OZONE)) || defined(OS_WIN)
alexmos 2017/03/30 17:16:11 What's wrong with the test on the excluded platfor
avallee 2017/04/02 02:27:30 For Mac, I wrote a sample that just prints mousemo
// Ensures that renderers know to advance focus to sibling frames and parent
// frames in the presence of mouse click initiated focus changes.
alexmos 2017/03/30 17:16:11 nit: I'd keep the reference to the bug here.
avallee 2017/04/02 02:27:30 Done.
IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest,
- DISABLED_TabAndMouseFocusNavigation) {
+ TabAndMouseFocusNavigation) {
GURL main_url(embedded_test_server()->GetURL(
"a.com", "/cross_site_iframe_factory.html?a(b,c)"));
ui_test_utils::NavigateToURL(browser(), main_url);
@@ -336,7 +336,6 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest,
// iframe: 55,18;55,67
std::string script =
"function onFocus(e) {"
- " console.log(window.name+'-focused-'+ e.target.id);"
" domAutomationController.setAutomationId(0);"
" domAutomationController.send(window.name + '-focused-' + e.target.id);"
"}"
@@ -474,6 +473,7 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest,
click_element_and_wait_for_message(main_frame_input_coords[0]))
<< "Unexpected extra focus events.";
}
+#endif
namespace {

Powered by Google App Engine
This is Rietveld 408576698