OOPIF: Enable TabAndMouseFocusNavigation.

chrome/browser/site_per_process_interactive_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/test/scoped_feature_list.h"
 #include "base/test/test_timeouts.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu_browsertest_util.h"
@@ skipping 284 matching lines @@
   EXPECT_EQ("\"child2-focused-input2\"", press_tab_and_wait_for_message(true));
   EXPECT_EQ(child2, web_contents->GetFocusedFrame());
   EXPECT_EQ("\"child2-focused-input1\"", press_tab_and_wait_for_message(true));
   EXPECT_EQ("\"child1-focused-input2\"", press_tab_and_wait_for_message(true));
   EXPECT_EQ(child1, web_contents->GetFocusedFrame());
   EXPECT_EQ("\"child1-focused-input1\"", press_tab_and_wait_for_message(true));
   EXPECT_EQ("\"root-focused-input1\"", press_tab_and_wait_for_message(true));
   EXPECT_EQ(main_frame, web_contents->GetFocusedFrame());
 }
 
-// TODO(https://crbug.com/702330): Enable this test.
+#if (defined(OS_LINUX) && !defined(USE_OZONE)) || defined(OS_WIN)

[alexmos, 2017/03/30 17:16:11]

What's wrong with the test on the excluded platforms?  Is it possible to get the
test working on Mac/ChromeOS?

[avallee, 2017/04/02 02:27:30]

For Mac, I wrote a sample that just prints mousemoves and there's nothing that
shows up.

On OZONE, the mousemoves seem to show up but then clicks don't happen.

 // Ensures that renderers know to advance focus to sibling frames and parent
 // frames in the presence of mouse click initiated focus changes.

[alexmos, 2017/03/30 17:16:11]

nit: I'd keep the reference to the bug here.

[avallee, 2017/04/02 02:27:30]

Done.

 IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest,
-                       DISABLED_TabAndMouseFocusNavigation) {
+                       TabAndMouseFocusNavigation) {
   GURL main_url(embedded_test_server()->GetURL(
       "a.com", "/cross_site_iframe_factory.html?a(b,c)"));
   ui_test_utils::NavigateToURL(browser(), main_url);
 
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
 
   content::RenderFrameHost* main_frame = web_contents->GetMainFrame();
   content::RenderFrameHost* child1 = ChildFrameAt(main_frame, 0);
   ASSERT_NE(nullptr, child1);
   content::RenderFrameHost* child2 = ChildFrameAt(main_frame, 1);
   ASSERT_NE(nullptr, child2);
 
   // Assign a name to each frame.  This will be sent along in test messages
   // from focus events.
   EXPECT_TRUE(ExecuteScript(main_frame, "window.name = 'root';"));
   EXPECT_TRUE(ExecuteScript(child1, "window.name = 'child1';"));
   EXPECT_TRUE(ExecuteScript(child2, "window.name = 'child2';"));
 
   // This script will insert two <input> fields in the document, one at the
   // beginning and one at the end.  For root frame, this means that we will
   // have an <input>, then two <iframe> elements, then another <input>.
   // The script will send back the coordinates to click for each <input>, in the
   // document's space. Additionally, the outer frame will return  the top left
   // point of each <iframe> to transform the coordinates of the inner <input>
   // elements. For example, main frame: 497,18;497,185:381,59;499,59 and each
   // iframe: 55,18;55,67
   std::string script =
       "function onFocus(e) {"
-      "  console.log(window.name+'-focused-'+ e.target.id);"
       "  domAutomationController.setAutomationId(0);"
       "  domAutomationController.send(window.name + '-focused-' + e.target.id);"
       "}"
       ""
       "function getElementCoords(element) {"
       "  var rect = element.getBoundingClientRect();"
       "  return Math.floor(rect.left + 0.5 * rect.width) +','+"
       "         Math.floor(rect.top + 0.5 * rect.height);"
       "}"
       "function getIframeCoords(element) {"
@@ skipping 117 matching lines @@
             click_element_and_wait_for_message(child2_input_coords[0]));
   EXPECT_EQ(child2, web_contents->GetFocusedFrame());
   EXPECT_EQ("\"child1-focused-input2\"", press_tab_and_wait_for_message(true));
   EXPECT_EQ(child1, web_contents->GetFocusedFrame());
 
   // Ensure there are no pending focus events after tabbing.
   EXPECT_EQ("\"root-focused-input1\"",
             click_element_and_wait_for_message(main_frame_input_coords[0]))
       << "Unexpected extra focus events.";
 }
+#endif
 
 namespace {
 
 // Helper to retrieve the frame's (window.innerWidth, window.innerHeight).
 gfx::Size GetFrameSize(content::RenderFrameHost* frame) {
   int width = 0;
   EXPECT_TRUE(ExecuteScriptAndExtractInt(
       frame, "domAutomationController.send(window.innerWidth);", &width));
 
   int height = 0;
@@ skipping 846 matching lines @@
 
   // Ideally, the length of the error vector should be 0.0f. But due to
   // potential rounding errors, we assume a larger limit (which is slightly
   // larger than square root of 2).
   EXPECT_LT(error.Length(), 1.4143f)
       << "Origin of bounds from focused node changed event is '"
       << focus_observer.focused_node_bounds_in_screen().ToString()
       << "' but AutofillClient is reporting '" << bounds_origin.ToString()
       << "'";
 }