Correct overlay scrollbar check FrameView::scrollbarExistenceDidChange

Correct overlay scrollbar check FrameView::scrollbarExistenceDidChange

This issue is caused by FrameView::scrollbarExistenceDidChange calculate
usesOverlayScrollbars via check ScrollbarTheme::theme() only but ignore custom
scrollbar then pass layout.

In this patch, we add the custom scrollbar check to correct
usesOverlayScrollbars.

BUG=668387
Review-Url: https://codereview.chromium.org/2780883002
Cr-Commit-Position: refs/heads/master@{#460377}
Committed: https://chromium.googlesource.com/chromium/src/+/b16307ca71933c12f9f1b85927a34f2052e86910

[bokan, 2017-03-28 21:11:08]

Description was changed from

==========
Correct overlay scrollbar check FrameView::scrollbarExistenceDidChange

This issue is caused by FrameView::scrollbarExistenceDidChange calculate
usesOverlayScrollbars via check ScrollbarTheme::theme() only but ignore custom
scrollbar then pass layout.

In this patch, we add the custom scrollbar check to correct
usesOverlayScrollbars.

BUG=668387
==========

to

==========
Correct overlay scrollbar check FrameView::scrollbarExistenceDidChange

This issue is caused by FrameView::scrollbarExistenceDidChange calculate
usesOverlayScrollbars via check ScrollbarTheme::theme() only but ignore custom
scrollbar then pass layout.

In this patch, we add the custom scrollbar check to correct
usesOverlayScrollbars.

BUG=668387
==========

[bokan, 2017-03-28 21:11:08]

bokan@chromium.org changed reviewers:
+ skobes@chromium.org

[bokan, 2017-03-28 21:11:50]

Steve, ptal.

Note: this CL was original put up by chaopeng@ here:
https://codereview.chromium.org/2744443003/

He was having a hard time figuring out how to recreate the bug in a test so I've
added a test in this CL.

[skobes, 2017-03-28 21:22:34]

https://codereview.chromium.org/2780883002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/ScrollbarsTest.cpp (right):

https://codereview.chromium.org/2780883002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/ScrollbarsTest.cpp:58:
DCHECK(ScrollbarTheme::theme().usesOverlayScrollbars());
Doesn't this DCHECK make the test crash on platforms that don't use overlay
scrollbars by default?

[bokan, 2017-03-28 21:26:32]

https://codereview.chromium.org/2780883002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/ScrollbarsTest.cpp (right):

https://codereview.chromium.org/2780883002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/ScrollbarsTest.cpp:58:
DCHECK(ScrollbarTheme::theme().usesOverlayScrollbars());
On 2017/03/28 21:22:34, skobes wrote:
> Doesn't this DCHECK make the test crash on platforms that don't use overlay
> scrollbars by default?

No, unit tests run with mock overlay scrollbars enabled because of
FrameTestHelpers.

[skobes, 2017-03-28 21:27:31]

lgtm

[bokan, 2017-03-28 21:30:39]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:30:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 21:41:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:41:15]

Exceeded global retry quota

[bokan, 2017-03-28 21:58:57]

The CQ bit was checked by bokan@chromium.org

[bokan, 2017-03-28 21:58:58]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2780883002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-28 21:59:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bokan, 2017-03-28 22:21:39]

The CQ bit was unchecked by bokan@chromium.org

[bokan, 2017-03-29 13:27:28]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2017-03-29 13:27:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 14:08:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490794048991700,
"parent_rev": "589474d1810ed2da8d67e541f45c94f53deda06f", "commit_rev":
"b16307ca71933c12f9f1b85927a34f2052e86910"}

[commit-bot: I haz the power, 2017-03-29 14:09:34]

Description was changed from

==========
Correct overlay scrollbar check FrameView::scrollbarExistenceDidChange

This issue is caused by FrameView::scrollbarExistenceDidChange calculate
usesOverlayScrollbars via check ScrollbarTheme::theme() only but ignore custom
scrollbar then pass layout.

In this patch, we add the custom scrollbar check to correct
usesOverlayScrollbars.

BUG=668387
==========

to

==========
Correct overlay scrollbar check FrameView::scrollbarExistenceDidChange

This issue is caused by FrameView::scrollbarExistenceDidChange calculate
usesOverlayScrollbars via check ScrollbarTheme::theme() only but ignore custom
scrollbar then pass layout.

In this patch, we add the custom scrollbar check to correct
usesOverlayScrollbars.

BUG=668387

Review-Url: https://codereview.chromium.org/2780883002
Cr-Commit-Position: refs/heads/master@{#460377}
Committed:
https://chromium.googlesource.com/chromium/src/+/b16307ca71933c12f9f1b85927a3...
==========

[commit-bot: I haz the power, 2017-03-29 14:09:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b16307ca71933c12f9f1b85927a3...