Add extra information for ReadingList ContentSuggestion

components/ntp_snippets/reading_list/reading_list_suggestions_provider.h

Index: components/ntp_snippets/reading_list/reading_list_suggestions_provider.h
diff --git a/components/ntp_snippets/reading_list/reading_list_suggestions_provider.h b/components/ntp_snippets/reading_list/reading_list_suggestions_provider.h
index fcb1c5e0f734d855410cfffba8e4ecdd368ae55f..e0b13020e08d339eda1a29ccf655f231ae195918 100644
--- a/components/ntp_snippets/reading_list/reading_list_suggestions_provider.h
+++ b/components/ntp_snippets/reading_list/reading_list_suggestions_provider.h
@@ -56,6 +56,10 @@ class ReadingListSuggestionsProvider : public ContentSuggestionsProvider,
   // model is loaded.
   void FetchReadingListInternal();
 
+  // Converts |entry| to ContentSuggestion and add it to |suggestions|.

[Olivier, 2017/03/28 13:43:46]

nit: The main goal of the method is to add the entry. Conversion is a tool.
So either rename it AddEntryToSuggestions, or make is return a
ContentSuggestion.

[gambard, 2017/03/29 06:51:24]

Done.

+  void ConvertEntry(const ReadingListEntry* entry,

[Olivier, 2017/03/28 13:43:46]

const & ?

[gambard, 2017/03/29 06:51:24]

I have a pointer (returned by the Reading List model).

[Marc Treib, 2017/03/29 08:24:58]

But you can still pass a reference here, to make clear that it can't be null.
(And that the pointer won't be kept around, though that's maybe less relevant
here.)

+                    std::vector<ContentSuggestion>* suggestions);
+
   // Updates the |category_status_| and notifies the |observer_|, if necessary.
   void NotifyStatusChanged(CategoryStatus new_status);
   CategoryStatus category_status_;