Add extra information for ReadingList ContentSuggestion

components/ntp_snippets/reading_list/reading_list_suggestions_provider.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_READING_LIST_READING_LIST_SUGGESTIONS_PROVIDER_H_
 #define COMPONENTS_NTP_SNIPPETS_READING_LIST_READING_LIST_SUGGESTIONS_PROVIDER_H_
 
 #include <set>
 #include <string>
 
@@ skipping 38 matching lines @@
 
   // ReadingListModelObserver implementation.
   void ReadingListModelLoaded(const ReadingListModel* model) override;
   void ReadingListModelBeingDeleted(const ReadingListModel* model) override;
 
  private:
   // The actual method to fetch Reading List entries. Must be called after the
   // model is loaded.
   void FetchReadingListInternal();
 
+  // Converts |entry| to ContentSuggestion and add it to |suggestions|.

[Olivier, 2017/03/28 13:43:46]

nit: The main goal of the method is to add the entry. Conversion is a tool.
So either rename it AddEntryToSuggestions, or make is return a
ContentSuggestion.

[gambard, 2017/03/29 06:51:24]

Done.

+  void ConvertEntry(const ReadingListEntry* entry,

[Olivier, 2017/03/28 13:43:46]

const & ?

[gambard, 2017/03/29 06:51:24]

I have a pointer (returned by the Reading List model).

[Marc Treib, 2017/03/29 08:24:58]

But you can still pass a reference here, to make clear that it can't be null.
(And that the pointer won't be kept around, though that's maybe less relevant
here.)

+                    std::vector<ContentSuggestion>* suggestions);
+
   // Updates the |category_status_| and notifies the |observer_|, if necessary.
   void NotifyStatusChanged(CategoryStatus new_status);
   CategoryStatus category_status_;
   const Category provided_category_;
 
   ReadingListModel* reading_list_model_;
 
   DISALLOW_COPY_AND_ASSIGN(ReadingListSuggestionsProvider);
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_READING_LIST_READING_LIST_SUGGESTIONS_PROVIDER_H_