Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2780783003: Separate function byte size counter for asm.js/wasm. (Closed)

Created:
3 years, 8 months ago by kschimpf
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Separate function byte size counter for asm.js/wasm. Currently, V8 uses the same size counter to measure function byte sizes for both asm.js and WASM. This CL separates the counter into two separate counters, and then uses the appropriate counter when decoding. BUG=chromium:704922 R=bbudge@google.com,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2780783003 Cr-Commit-Position: refs/heads/master@{#44205} Committed: https://chromium.googlesource.com/v8/v8/+/d7d201d4128f573917c5cef67c8ef3fce63e73bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M src/counters.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/wasm/module-decoder.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
kschimpf
Please review. Thanks.
3 years, 8 months ago (2017-03-28 15:33:06 UTC) #5
bradnelson
lgtm
3 years, 8 months ago (2017-03-28 18:15:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780783003/1
3 years, 8 months ago (2017-03-28 18:15:20 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 18:18:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d7d201d4128f573917c5cef67c8ef3fce63...

Powered by Google App Engine
This is Rietveld 408576698