components/payments/content/payment_request.cc - Issue 2780773004: Reland "PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/payments/content/payment_request.cc

Issue 2780773004: Reland "PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate." (Closed)

Patch Set: Reland "PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate." Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/payments/content/payment_request.cc

diff --git a/components/payments/content/payment_request.cc b/components/payments/content/payment_request.cc

index ed48db057bf30588400e06c8a5f6d8b336445309..d748039c31300aaa8fe8c7ac3d8d05463c801a17 100644

--- a/components/payments/content/payment_request.cc

+++ b/components/payments/content/payment_request.cc

@@ -48,6 +48,11 @@ void PaymentRequest::Init(

OnConnectionTerminated();

return;

}

+ if (!details->total) {

+ LOG(ERROR) << "Missing total";

+ OnConnectionTerminated();

+ return;

+ }

client_ = std::move(client);

spec_ = base::MakeUnique<PaymentRequestSpec>(

std::move(options), std::move(details), std::move(method_data), this,