Reland "PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate."

Reland "PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate."

Reason for revert:
This CL broke compilation on Android and Mac. (https://crbug.com/704166)

Original issue's description:
> The current implementation uses PaymentDetails structure when creating
> PaymentRequest object and calling updateWith(). But some parameters like error
> are only allowed in the updateWith(). If developer tries to use error
> parameter when creating PaymentRequest, then throws exception. So, to solve
> the problem in the latest spec[1][2], common parts are combined and each
> different parts are separated into PaymentDetailsInit and
> PaymentDetailsUpdate.
>
> This change only affects input dictionaries and doesn't break existing
> behavior. Therefore, we don't need a intent to implement and ship.
>
> [1] https://w3c.github.io/browser-payment-api/#paymentdetailsinit-dictionary
> [2] https://w3c.github.io/browser-payment-api/#paymentdetailsupdate-dictionary
>
> BUG=704166
>
> Review-Url: https://codereview.chromium.org/2748093003
> Cr-Commit-Position: refs/heads/master@{#460053}
> Committed: https://chromium.googlesource.com/chromium/src/+/aec033c55fbc09dade60bc543373deb86c517b1b

BUG=704166
Review-Url: https://codereview.chromium.org/2780773004
Cr-Commit-Position: refs/heads/master@{#460323}
Committed: https://chromium.googlesource.com/chromium/src/+/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b

[zino, 2017-03-28 13:19:23]

Description was changed from

==========
Reland "PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate."

Reason for revert:
This CL broke compilation on Android and Mac. (https://crbug.com/704166)

Original issue's description:
> The current implementation uses PaymentDetails structure when creating
> PaymentRequest object and calling updateWith(). But some parameters like error
> are only allowed in the updateWith(). If developer tries to use error
> parameter when creating PaymentRequest, then throws exception. So, to solve
> the problem in the latest spec[1][2], common parts are combined and each
> different parts are separated into PaymentDetailsInit and
> PaymentDetailsUpdate.
>
> This change only affects input dictionaries and doesn't break existing
> behavior. Therefore, we don't need a intent to implement and ship.
>
> [1] https://w3c.github.io/browser-payment-api/#paymentdetailsinit-dictionary
> [2] https://w3c.github.io/browser-payment-api/#paymentdetailsupdate-dictionary
>
> BUG=704166
>
> Review-Url: https://codereview.chromium.org/2748093003
> Cr-Commit-Position: refs/heads/master@{#460053}
> Committed:
https://chromium.googlesource.com/chromium/src/+/aec033c55fbc09dade60bc543373...

BUG=704166
==========

to

==========
Reland "PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate."

Reason for revert:
This CL broke compilation on Android and Mac. (https://crbug.com/704166)

Original issue's description:
> The current implementation uses PaymentDetails structure when creating
> PaymentRequest object and calling updateWith(). But some parameters like error
> are only allowed in the updateWith(). If developer tries to use error
> parameter when creating PaymentRequest, then throws exception. So, to solve
> the problem in the latest spec[1][2], common parts are combined and each
> different parts are separated into PaymentDetailsInit and
> PaymentDetailsUpdate.
>
> This change only affects input dictionaries and doesn't break existing
> behavior. Therefore, we don't need a intent to implement and ship.
>
> [1] https://w3c.github.io/browser-payment-api/#paymentdetailsinit-dictionary
> [2] https://w3c.github.io/browser-payment-api/#paymentdetailsupdate-dictionary
>
> BUG=704166
>
> Review-Url: https://codereview.chromium.org/2748093003
> Cr-Commit-Position: refs/heads/master@{#460053}
> Committed:
https://chromium.googlesource.com/chromium/src/+/aec033c55fbc09dade60bc543373...

BUG=704166
==========

[zino, 2017-03-28 13:19:23]

jinho.bang@samsung.com changed reviewers:
+ haraken@chromium.org, rouslan@chromium.org, tsepez@chromium.org

[zino, 2017-03-28 13:25:55]

PTAL

haraken@ for modules/*
rouslan@ for payments/*
Tom Sepez@ for mojom

https://codereview.chromium.org/2780773004/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
(right):

https://codereview.chromium.org/2780773004/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp:13:
#include "modules/payments/PaymentDetailsInit.h"
I forgot to change this line in the reverted previous patch.
I don't know how the trybot worked well for previous patch.
Not sure but the generated header file was cached I doubt.

[please use gerrit instead, 2017-03-28 14:14:02]

Please upload two patches. One called "Original" and the second one called
"Fix". That way reviewers don't have to re-review everything once again. Thank
you!

[zino, 2017-03-28 14:29:17]

On 2017/03/28 14:14:02, ಠ_ಠ wrote:
> Please upload two patches. One called "Original" and the second one called
> "Fix". That way reviewers don't have to re-review everything once again. Thank
> you!

Your idea is good. :)
Thank you for guide.

PTAL.

[please use gerrit instead, 2017-03-28 14:35:22]

lgtm

[haraken, 2017-03-28 15:55:04]

LGTM

[Tom Sepez, 2017-03-28 16:41:24]

lgtm

[zino, 2017-03-28 16:45:10]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2017-03-28 16:45:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 18:27:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 18:27:08]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[zino, 2017-03-28 22:08:49]

On 2017/03/28 18:27:08, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Rebased due to https://codereview.chromium.org/2766823003.
Thanks.

[zino, 2017-03-28 22:08:54]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-03-28 22:08:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tsepez@chromium.org, rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2780773004/#ps60001
(title: "Reland "PaymentRequest: Introduce PaymentDetailsInit and
PaymentDetailsUpdate."")

[commit-bot: I haz the power, 2017-03-28 22:09:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 22:30:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 22:30:11]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[zino, 2017-03-29 00:42:07]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2017-03-29 00:42:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 02:29:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 02:29:06]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[zino, 2017-03-29 06:09:51]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2017-03-29 06:10:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 08:08:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490767791108010,
"parent_rev": "28ea8191e57cf1a852a9e48f5298a3049687b006", "commit_rev":
"fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b"}

[commit-bot: I haz the power, 2017-03-29 08:08:53]

Description was changed from

==========
Reland "PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate."

Reason for revert:
This CL broke compilation on Android and Mac. (https://crbug.com/704166)

Original issue's description:
> The current implementation uses PaymentDetails structure when creating
> PaymentRequest object and calling updateWith(). But some parameters like error
> are only allowed in the updateWith(). If developer tries to use error
> parameter when creating PaymentRequest, then throws exception. So, to solve
> the problem in the latest spec[1][2], common parts are combined and each
> different parts are separated into PaymentDetailsInit and
> PaymentDetailsUpdate.
>
> This change only affects input dictionaries and doesn't break existing
> behavior. Therefore, we don't need a intent to implement and ship.
>
> [1] https://w3c.github.io/browser-payment-api/#paymentdetailsinit-dictionary
> [2] https://w3c.github.io/browser-payment-api/#paymentdetailsupdate-dictionary
>
> BUG=704166
>
> Review-Url: https://codereview.chromium.org/2748093003
> Cr-Commit-Position: refs/heads/master@{#460053}
> Committed:
https://chromium.googlesource.com/chromium/src/+/aec033c55fbc09dade60bc543373...

BUG=704166
==========

to

==========
Reland "PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate."

Reason for revert:
This CL broke compilation on Android and Mac. (https://crbug.com/704166)

Original issue's description:
> The current implementation uses PaymentDetails structure when creating
> PaymentRequest object and calling updateWith(). But some parameters like error
> are only allowed in the updateWith(). If developer tries to use error
> parameter when creating PaymentRequest, then throws exception. So, to solve
> the problem in the latest spec[1][2], common parts are combined and each
> different parts are separated into PaymentDetailsInit and
> PaymentDetailsUpdate.
>
> This change only affects input dictionaries and doesn't break existing
> behavior. Therefore, we don't need a intent to implement and ship.
>
> [1] https://w3c.github.io/browser-payment-api/#paymentdetailsinit-dictionary
> [2] https://w3c.github.io/browser-payment-api/#paymentdetailsupdate-dictionary
>
> BUG=704166
>
> Review-Url: https://codereview.chromium.org/2748093003
> Cr-Commit-Position: refs/heads/master@{#460053}
> Committed:
https://chromium.googlesource.com/chromium/src/+/aec033c55fbc09dade60bc543373...

BUG=704166

Review-Url: https://codereview.chromium.org/2780773004
Cr-Commit-Position: refs/heads/master@{#460323}
Committed:
https://chromium.googlesource.com/chromium/src/+/fcb5ec998c25a649fab3bbbc3ab1...
==========

[commit-bot: I haz the power, 2017-03-29 08:08:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fcb5ec998c25a649fab3bbbc3ab1...