Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2780743002: Remove pre-MD code from TrayDetailsView. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank, jshin+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove pre-MD code from TrayDetailsView. Remove SpecialPopupRow. BUG=686220 Review-Url: https://codereview.chromium.org/2780743002 Cr-Commit-Position: refs/heads/master@{#460527} Committed: https://chromium.googlesource.com/chromium/src/+/1653e00e3ecd7b208e4fb00265492263c86367bf

Patch Set 1 #

Patch Set 2 : relative #

Total comments: 2

Patch Set 3 : rebase + fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -360 lines) Patch
M ash/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/audio/tray_audio.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
D ash/common/system/tray/special_popup_row.h View 1 chunk +0 lines, -67 lines 0 comments Download
D ash/common/system/tray/special_popup_row.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M ash/common/system/tray/tray_details_view.h View 4 chunks +1 line, -4 lines 0 comments Download
M ash/common/system/tray/tray_details_view.cc View 1 17 chunks +30 lines, -114 lines 0 comments Download
M ash/common/system/tray/tray_details_view_unittest.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 1 chunk +0 lines, -1 line 0 comments Download
D ash/resources/default_100_percent/cros/status/status_less.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_less.png View Binary file 0 comments Download

Messages

Total messages: 10 (5 generated)
Evan Stade
depends on https://codereview.chromium.org/2781793002/
3 years, 9 months ago (2017-03-28 03:22:38 UTC) #2
tdanderson
LGTM https://codereview.chromium.org/2780743002/diff/20001/ash/common/system/tray/tray_details_view.h File ash/common/system/tray/tray_details_view.h (right): https://codereview.chromium.org/2780743002/diff/20001/ash/common/system/tray/tray_details_view.h#newcode126 ash/common/system/tray/tray_details_view.h:126: ScrollBorder* scroll_border_; // Weak reference I believe you ...
3 years, 8 months ago (2017-03-28 22:46:01 UTC) #3
Evan Stade
https://codereview.chromium.org/2780743002/diff/20001/ash/common/system/tray/tray_details_view.h File ash/common/system/tray/tray_details_view.h (right): https://codereview.chromium.org/2780743002/diff/20001/ash/common/system/tray/tray_details_view.h#newcode126 ash/common/system/tray/tray_details_view.h:126: ScrollBorder* scroll_border_; // Weak reference On 2017/03/28 22:46:00, tdanderson ...
3 years, 8 months ago (2017-03-29 19:08:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780743002/40001
3 years, 8 months ago (2017-03-29 19:11:03 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:45:08 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1653e00e3ecd7b208e4fb0026549...

Powered by Google App Engine
This is Rietveld 408576698