Hide compositor_frame_sink_id from RenderWidgetHostView*

Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. When
DidCreateNewRendererCompositorFrameSink is called, the views ensure
that they never return resources of the old RendererCompositorFrameSink
by recreating CompositorFrameSinkSupport.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2780713004
Cr-Commit-Position: refs/heads/master@{#460504}
Committed: https://chromium.googlesource.com/chromium/src/+/40e8020cbd6c9920cef435a68d5c38addff57c6a

[Saman Sami, 2017-03-28 17:44:34]

Description was changed from

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

bug=697864
==========

to

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-03-28 17:45:16]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 17:46:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-03-28 17:47:04]

Description was changed from

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id will go away once we switch to mojo, so it 
should not be exposed.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-03-28 17:48:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 17:48:52]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Saman Sami, 2017-03-28 18:13:31]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 18:13:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 18:26:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 18:26:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Saman Sami, 2017-03-28 18:29:34]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 18:29:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-03-28 18:30:12]

Description was changed from

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id will go away once we switch to mojo, so it 
should not be exposed.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-03-28 18:36:10]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 18:36:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-03-28 18:50:28]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 18:50:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 19:04:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 19:04:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Saman Sami, 2017-03-28 19:18:58]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 19:19:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-03-28 19:23:56]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 19:24:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-03-28 19:44:10]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-03-28 19:44:17]

samans@chromium.org changed reviewers:
+ fsamuel@chromium.org

[commit-bot: I haz the power, 2017-03-28 19:44:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-03-28 19:45:29]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 19:46:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-03-28 19:46:04]

PTAL

[commit-bot: I haz the power, 2017-03-28 20:06:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 20:06:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2017-03-28 20:20:06]

Could you please add a longer description of how you actually accomplished this?
It would be helpful to see without reading all the code in the future. However,
this approach looks good to me once all the bots are green.

[Saman Sami, 2017-03-28 20:29:42]

Description was changed from

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. All the views care about right now
is when the value changes, not the value itself.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-03-28 20:30:32]

Description was changed from

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. All the views care about right now
is when the value changes, not the value itself.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. All the views care about right now
is change of the id, not the value of the id itself.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-03-28 20:30:53]

Description was changed from

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. All the views care about right now
is change of the id, not the value of the id itself.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. What all the views care about right 
now is change of the id, not the value of the id itself.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-03-28 20:43:42]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 20:44:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 21:15:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:15:09]

Dry run: CQ has no permission to schedule in bucket
master.tryserver.chromium.linux

[Saman Sami, 2017-03-28 21:16:09]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 21:16:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 21:16:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:16:48]

Dry run: CQ has no permission to schedule in bucket
master.tryserver.chromium.linux

[Saman Sami, 2017-03-28 22:27:54]

Description was changed from

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. What all the views care about right 
now is change of the id, not the value of the id itself.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. What all the views care about right 
now is change in the value of id, not the value itself.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-03-28 22:27:55]

samans@chromium.org changed reviewers:
+ piman@chromium.org

[Saman Sami, 2017-03-28 22:28:05]

Description was changed from

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. What all the views care about right 
now is change in the value of id, not the value itself.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. What all the views care about right 
now is change in the value of id, not the id itself.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-03-28 22:32:09]

PTAL

[Fady Samuel, 2017-03-28 22:33:41]

lgtm

[Saman Sami, 2017-03-28 22:58:37]

Description was changed from

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. What all the views care about right 
now is change in the value of id, not the id itself.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. When
DidCreateNewRendererCompositorFrameSink is called, the views ensure
that they never return resources of the old RendererCompositorFrameSink
by recreating CompositorFrameSinkSupport.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[piman, 2017-03-28 23:07:46]

https://codereview.chromium.org/2780713004/diff/200001/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2780713004/diff/200001/content/browser/render...
content/browser/renderer_host/render_widget_host_view_android.cc:1124:
surface_returned_resources_.clear();
Is it ok not to return the resources? Why?

https://codereview.chromium.org/2780713004/diff/200001/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/2780713004/diff/200001/content/browser/render...
content/browser/renderer_host/render_widget_host_view_aura.cc:878:
delegated_frame_host_->DidCreateNewRendererCompositorFrameSink();
delegated_frame_host_ may be null.

[Saman Sami, 2017-03-28 23:35:39]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-03-28 23:36:31]

https://codereview.chromium.org/2780713004/diff/200001/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2780713004/diff/200001/content/browser/render...
content/browser/renderer_host/render_widget_host_view_android.cc:1124:
surface_returned_resources_.clear();
On 2017/03/28 23:07:46, piman wrote:
> Is it ok not to return the resources? Why?

Because the resources we currently have belong to the old
RendererCompositorFrameSink and should not be sent back. See
RendererCompositorFrameSink::OnReclaimCompositorResources, it discards resources
belonging to old frame sinks.

I'm actually gonna move this line to the end of this function. I'm worried that
the line below might populate surfaces_returned_resources_.

https://codereview.chromium.org/2780713004/diff/200001/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/2780713004/diff/200001/content/browser/render...
content/browser/renderer_host/render_widget_host_view_aura.cc:878:
delegated_frame_host_->DidCreateNewRendererCompositorFrameSink();
On 2017/03/28 23:07:46, piman wrote:
> delegated_frame_host_ may be null.

Done.

[commit-bot: I haz the power, 2017-03-28 23:36:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:38:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:38:26]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[Saman Sami, 2017-03-29 02:44:44]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 02:45:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 04:16:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 04:16:50]

Dry run: This issue passed the CQ dry run.

[piman, 2017-03-29 17:41:49]

lgtm

https://codereview.chromium.org/2780713004/diff/200001/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2780713004/diff/200001/content/browser/render...
content/browser/renderer_host/render_widget_host_view_android.cc:1124:
surface_returned_resources_.clear();
On 2017/03/28 23:36:30, Saman Sami wrote:
> On 2017/03/28 23:07:46, piman wrote:
> > Is it ok not to return the resources? Why?
> 
> Because the resources we currently have belong to the old
> RendererCompositorFrameSink and should not be sent back. See
> RendererCompositorFrameSink::OnReclaimCompositorResources, it discards
resources
> belonging to old frame sinks.
> 
> I'm actually gonna move this line to the end of this function. I'm worried
that
> the line below might populate surfaces_returned_resources_.

Maybe worth a comment.

[Saman Sami, 2017-03-29 18:22:22]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 18:23:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-03-29 18:26:09]

Thanks for the LGTMs. I updated RenderWidgetHostImpl tests. I got rid of the
swap IPC message and instead we call SubmitCompositorFrame directly. Also, I
added a test that ensures RWHI properly keeps track of last
compositor_frame_sink_id and notifies the view when it changes. We no longer
have test coverage for this in RenderWidgetHostViewAura unit tests so I thought
it'll be useful to have that test.

[Saman Sami, 2017-03-29 18:28:44]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Fady Samuel, 2017-03-29 18:28:51]

On 2017/03/29 18:26:09, Saman Sami wrote:
> Thanks for the LGTMs. I updated RenderWidgetHostImpl tests. I got rid of the
> swap IPC message and instead we call SubmitCompositorFrame directly. Also, I
> added a test that ensures RWHI properly keeps track of last
> compositor_frame_sink_id and notifies the view when it changes. We no longer
> have test coverage for this in RenderWidgetHostViewAura unit tests so I
thought
> it'll be useful to have that test.

Thanks for the new unit test and updating the existing unit tests to be
IPC-agnostic! Still LGTM!

[commit-bot: I haz the power, 2017-03-29 18:29:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-03-29 18:42:38]

The CQ bit was unchecked by samans@chromium.org

[Saman Sami, 2017-03-29 18:42:39]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-03-29 18:42:39]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2780713004/#ps260001
(title: "Added a comment in android")

[commit-bot: I haz the power, 2017-03-29 18:43:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 19:59:17]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1490812959328540,
"parent_rev": "0f51324df2b3f6a90d7454fe66a17c012bd16277", "commit_rev":
"40e8020cbd6c9920cef435a68d5c38addff57c6a"}

[commit-bot: I haz the power, 2017-03-29 20:00:05]

Description was changed from

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. When
DidCreateNewRendererCompositorFrameSink is called, the views ensure
that they never return resources of the old RendererCompositorFrameSink
by recreating CompositorFrameSinkSupport.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Hide compositor_frame_sink_id from RenderWidgetHostView*

compositor_frame_sink_id won't exist once we switch to mojo, so it 
should not be exposed to non-IPC methods. Instead of passing
compositor_frame_sink_id to the views, we just keep track of it in 
RenderWidgetHostImpl and call DidCreateNewRendererCompositorFrameSink 
on the view when its value changes. When
DidCreateNewRendererCompositorFrameSink is called, the views ensure
that they never return resources of the old RendererCompositorFrameSink
by recreating CompositorFrameSinkSupport.

bug=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2780713004
Cr-Commit-Position: refs/heads/master@{#460504}
Committed:
https://chromium.googlesource.com/chromium/src/+/40e8020cbd6c9920cef435a68d5c...
==========

[commit-bot: I haz the power, 2017-03-29 20:00:07]

Committed patchset #14 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/40e8020cbd6c9920cef435a68d5c...