Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2780693004: Add checks to track down AudioClock crash. (Closed)

Created:
3 years, 8 months ago by chcunningham
Modified:
3 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add checks to track down AudioClock crash. A few hundred crash reports in rendering path during execution of AudioClock::ComputeBufferedMediaDurationMicros. Locks and various contracts should protect us, so I assume one of the contracts is being broken and hope to find out where. AudioClock's buffered_ field is only modified during Render() and during destruction. Perhaps its being destroyed while still in-use. BUG=674856 Review-Url: https://codereview.chromium.org/2780693004 Cr-Commit-Position: refs/heads/master@{#460637} Committed: https://chromium.googlesource.com/chromium/src/+/20f1d3ad8fc29955bc0e1b7a4dcb8e887cb613a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M media/renderers/audio_renderer_impl.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
chcunningham
3 years, 8 months ago (2017-03-28 22:16:23 UTC) #2
DaleCurtis
Seems reasonable. I had to double check that Lock::Try is actually implemented on all platforms.
3 years, 8 months ago (2017-03-29 22:54:02 UTC) #7
DaleCurtis
lgtm
3 years, 8 months ago (2017-03-29 22:54:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780693004/1
3 years, 8 months ago (2017-03-30 00:45:28 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 03:16:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20f1d3ad8fc29955bc0e1b7a4dcb...

Powered by Google App Engine
This is Rietveld 408576698