Include LogDog viewer links in message.

Include LogDog viewer links in message.

In LogDog-only mode, the actual text emitted to the base stream is just
a placeholder referencing LogDog-only mode. Add text to that placeholder
that points to the LogDog links, just in case a user is directed to the
stream.

BUG=chromium:701201
TEST=None
R=hinoka@chromium.org

Review-Url: https://codereview.chromium.org/2780673002
Committed: https://github.com/luci/luci-go/commit/cb672ae7ae5be63e439de79cb0761299e888d00a

[hinoka, 2017-03-27 22:21:05]

lgtm + comments

https://codereview.chromium.org/2780673002/diff/1/logdog/client/annotee/proce...
File logdog/client/annotee/processor.go (right):

https://codereview.chromium.org/2780673002/diff/1/logdog/client/annotee/proce...
logdog/client/annotee/processor.go:362: "Please use the LogDog link on the build
page to view this log stream.")
This seems like a better place to inject the viewer links.

eg. Please use the LogDog link on the build page or visit
https://luci-logdog.appspot.com/.....

https://codereview.chromium.org/2780673002/diff/1/logdog/client/annotee/proce...
logdog/client/annotee/processor.go:373: if len(injectTextStreamLines) > 0 {
the if statement is redundant.

https://codereview.chromium.org/2780673002/diff/1/logdog/client/annotee/proce...
logdog/client/annotee/processor.go:714: func (h *stepHandler)
flushInjectedAnnotations() []string {
This method and the one below looks like they could be inlined now.

[dnj, 2017-03-27 22:24:14]

https://codereview.chromium.org/2780673002/diff/1/logdog/client/annotee/proce...
File logdog/client/annotee/processor.go (right):

https://codereview.chromium.org/2780673002/diff/1/logdog/client/annotee/proce...
logdog/client/annotee/processor.go:362: "Please use the LogDog link on the build
page to view this log stream.")
On 2017/03/27 22:21:05, hinoka wrote:
> This seems like a better place to inject the viewer links.
> 
> eg. Please use the LogDog link on the build page or visit
> https://luci-logdog.appspot.com/.....

We can't inject here, since the links aren't known until a stream is actually
generated for a step, but this happens the moment a step is created.

What will likely happen is:

Round 1) This message gets printed.
Round 2) New stream (STDOUT) is created, inject text, text gets printed.
Round 3) New stream (STDERR) is created, inject text, text gets printed.
etc.

https://codereview.chromium.org/2780673002/diff/1/logdog/client/annotee/proce...
logdog/client/annotee/processor.go:373: if len(injectTextStreamLines) > 0 {
On 2017/03/27 22:21:05, hinoka wrote:
> the if statement is redundant.

Done.

https://codereview.chromium.org/2780673002/diff/1/logdog/client/annotee/proce...
logdog/client/annotee/processor.go:714: func (h *stepHandler)
flushInjectedAnnotations() []string {
On 2017/03/27 22:21:05, hinoka wrote:
> This method and the one below looks like they could be inlined now.

The method up there is huge enough. I'd like to keep it from operating on
internal data members here.

[dnj, 2017-03-27 22:24:28]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-03-27 22:24:28]

The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@chromium.org
Link to the patchset: https://codereview.chromium.org/2780673002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-03-27 22:24:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 22:31:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490653468420110,
"parent_rev": "9c353a31df60535ce05509c32a6671ba84c3f2a5", "commit_rev":
"cb672ae7ae5be63e439de79cb0761299e888d00a"}

[commit-bot: I haz the power, 2017-03-27 22:31:53]

Description was changed from

==========
Include LogDog viewer links in message.

In LogDog-only mode, the actual text emitted to the base stream is just
a placeholder referencing LogDog-only mode. Add text to that placeholder
that points to the LogDog links, just in case a user is directed to the
stream.

BUG=chromium:701201
TEST=None
R=hinoka@chromium.org
==========

to

==========
Include LogDog viewer links in message.

In LogDog-only mode, the actual text emitted to the base stream is just
a placeholder referencing LogDog-only mode. Add text to that placeholder
that points to the LogDog links, just in case a user is directed to the
stream.

BUG=chromium:701201
TEST=None
R=hinoka@chromium.org

Review-Url: https://codereview.chromium.org/2780673002
Committed:
https://github.com/luci/luci-go/commit/cb672ae7ae5be63e439de79cb0761299e888d00a
==========

[commit-bot: I haz the power, 2017-03-27 22:31:54]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/cb672ae7ae5be63e439de79cb0761299e888d00a