Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2780583003: [Presentation API] Move sandbox check to PresentationRequest ctor (Closed)

Created:
3 years, 9 months ago by zhaobin
Modified:
3 years, 8 months ago
Reviewers:
mark a. foltz, imcheng
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Presentation API] Move sandbox check to PresentationRequest ctor Fix PresentationRequest_sandboxing_error.html. BUG=705170

Patch Set 1 #

Patch Set 2 : add layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -15 lines) Patch
A third_party/WebKit/LayoutTests/presentation/presentation-request-sandbox-error.html View 1 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/presentation/presentation-request-sandbox-success.html View 1 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/presentation/resources/iframe-sandbox.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp View 5 chunks +6 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
zhaobin
3 years, 9 months ago (2017-03-27 19:37:43 UTC) #2
imcheng
lgtm
3 years, 9 months ago (2017-03-27 23:15:42 UTC) #3
mark a. foltz
lgtm
3 years, 9 months ago (2017-03-27 23:38:07 UTC) #4
mark a. foltz
ALso, it would be great to write layout test for this (assuming one was missing ...
3 years, 9 months ago (2017-03-27 23:38:48 UTC) #5
zhaobin
On 2017/03/27 23:38:48, mark a. foltz wrote: > ALso, it would be great to write ...
3 years, 9 months ago (2017-03-28 00:42:24 UTC) #7
mark a. foltz
lgtm
3 years, 8 months ago (2017-03-28 15:59:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780583003/20001
3 years, 8 months ago (2017-03-28 16:00:00 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 17:32:13 UTC) #16
Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698