Separate module decoding counter into asm and wasm counters.

Separate module decoding counter into asm and wasm counters.

Currently, V8 uses the same counter to collect decoding time for both asm.js and
WASM. This separates that counter into two separate counters, and then uses the appropriate counter when instantiating a module.

BUG=chromium:704922
R=bbudge@chromium.org,mtrofin@chromium.org

Review-Url: https://codereview.chromium.org/2780563002
Cr-Commit-Position: refs/heads/master@{#44163}
Committed: https://chromium.googlesource.com/v8/v8/+/15247047e5b63f41d96a509ff91d438ef66f14f2

[Karl, 2017-03-27 15:54:01]

Description was changed from

==========
Separate module decoding counter into asm and wasm counters.

Currently, V8 uses the same counter to collect decoding time for both asm.js and
WASM. This separates that counter into two separate counters, and then uses the
appropriate counter when instantiating a module.

BUG=chromium:704922
==========

to

==========
Separate module decoding counter into asm and wasm counters.

Currently, V8 uses the same counter to collect decoding time for both asm.js and
WASM. This separates that counter into two separate counters, and then uses the
appropriate counter when instantiating a module.

BUG=chromium:704922
R=bbudge@chromium.org,mtrofin@chromium.org
==========

[Karl, 2017-03-27 15:54:02]

kschimpf@google.com changed reviewers:
+ bbudge@chromium.org, mtrofin@chromium.org

[Karl, 2017-03-27 15:56:01]

kschimpf@google.com changed reviewers:
+ kschimpf@google.com

[Karl, 2017-03-27 15:56:36]

kschimpf@google.com changed reviewers:
- kschimpf@google.com

[kschimpf, 2017-03-27 16:51:46]

The CQ bit was checked by kschimpf@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 16:51:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 16:51:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 16:51:53]

Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[kschimpf, 2017-03-27 16:52:14]

The CQ bit was checked by kschimpf@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 16:52:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 16:52:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 16:52:24]

Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[Karl, 2017-03-27 16:53:34]

The CQ bit was checked by kschimpf@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 16:53:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 17:18:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 17:18:39]

Dry run: This issue passed the CQ dry run.

[bbudge, 2017-03-27 17:23:56]

https://codereview.chromium.org/2780563002/diff/1/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/2780563002/diff/1/src/wasm/wasm-module.h#newc...
src/wasm/wasm-module.h:141: inline bool is_wasm(ModuleOrigin Origin) {
Nit: Camel case for functions that aren't simple getters/setters on a class.

[kschimpf, 2017-03-27 19:46:36]

https://codereview.chromium.org/2780563002/diff/1/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/2780563002/diff/1/src/wasm/wasm-module.h#newc...
src/wasm/wasm-module.h:141: inline bool is_wasm(ModuleOrigin Origin) {
On 2017/03/27 17:23:56, bbudge wrote:
> Nit: Camel case for functions that aren't simple getters/setters on a class.

Done.

[kschimpf, 2017-03-27 19:47:21]

The CQ bit was checked by kschimpf@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 19:47:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 19:47:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 19:47:29]

Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[bbudge, 2017-03-27 20:03:40]

LGTM modulo naming change

https://codereview.chromium.org/2780563002/diff/20001/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/2780563002/diff/20001/src/wasm/wasm-module.h#...
src/wasm/wasm-module.h:141: inline bool isWasm(ModuleOrigin Origin) {
Sorry I wasn't more clear: these should be IsWasm, IsAsmJs.

[kschimpf, 2017-03-27 20:35:16]

https://codereview.chromium.org/2780563002/diff/20001/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/2780563002/diff/20001/src/wasm/wasm-module.h#...
src/wasm/wasm-module.h:141: inline bool isWasm(ModuleOrigin Origin) {
On 2017/03/27 20:03:40, bbudge wrote:
> Sorry I wasn't more clear: these should be IsWasm, IsAsmJs.

Done.

[kschimpf, 2017-03-27 20:35:22]

The CQ bit was checked by kschimpf@chromium.org

[kschimpf, 2017-03-27 20:35:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org
Link to the patchset: https://codereview.chromium.org/2780563002/#ps40001
(title: "Rename isWasm and isAsmJs to IsWasm and IsAsmJs.")

[commit-bot: I haz the power, 2017-03-27 20:35:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 20:38:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 20:38:02]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37768)

[bradnelson, 2017-03-27 20:42:13]

bradnelson@chromium.org changed reviewers:
+ bradnelson@chromium.org

[bradnelson, 2017-03-27 20:42:13]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2017-03-27 20:42:14]

lgtm

[commit-bot: I haz the power, 2017-03-27 20:42:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 21:03:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490647333357870,
"parent_rev": "32fdc6942451fe9414303812ef8dccfcdfc7f98f", "commit_rev":
"15247047e5b63f41d96a509ff91d438ef66f14f2"}

[commit-bot: I haz the power, 2017-03-27 21:03:45]

Description was changed from

==========
Separate module decoding counter into asm and wasm counters.

Currently, V8 uses the same counter to collect decoding time for both asm.js and
WASM. This separates that counter into two separate counters, and then uses the
appropriate counter when instantiating a module.

BUG=chromium:704922
R=bbudge@chromium.org,mtrofin@chromium.org
==========

to

==========
Separate module decoding counter into asm and wasm counters.

Currently, V8 uses the same counter to collect decoding time for both asm.js and
WASM. This separates that counter into two separate counters, and then uses the
appropriate counter when instantiating a module.

BUG=chromium:704922
R=bbudge@chromium.org,mtrofin@chromium.org

Review-Url: https://codereview.chromium.org/2780563002
Cr-Commit-Position: refs/heads/master@{#44163}
Committed:
https://chromium.googlesource.com/v8/v8/+/15247047e5b63f41d96a509ff91d438ef66...
==========

[commit-bot: I haz the power, 2017-03-27 21:03:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/15247047e5b63f41d96a509ff91d438ef66...