m58 merge QUIC: mark QUIC handshake failed if connection is closed after CryptoConnect

QUIC: mark QUIC handshake failed if connection is closed after CryptoConnect so that QuicStreamFactory::Job will not hang.

Currently, if QuicConnection is closed during crypto_stream_->CryptConnect(),
it will silently post a task to notify QuicStreamFactory to of the session
close without notifying the QuicStreamFactory::Job. This causes
QuicStreamFactory::Job to hang. Subsequent alt jobs will be bound to the
hanging QUIC job, and will never win race over TCP and get cleaned up.

BUG=700617
Review-Url: https://codereview.chromium.org/2766603004
Cr-Commit-Position: refs/heads/master@{#459271}
(cherry picked from commit 363c91c57a5ae99e63a138555afa83dc02262325)

R=rch@chromium.org

Review-Url: https://codereview.chromium.org/2780523002 .
Cr-Commit-Position: refs/branch-heads/3029@{#435}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/0a4d3c147a0f52493a850051008e1fe57c125d30

[Zhongyi Shi, 2017-03-27 15:06:39]

zhongyi@chromium.org changed reviewers:
+ rch@chromium.org, xunjieli@chromium.org

[Ryan Hamilton, 2017-03-27 16:56:15]

lgtm

Can you add "[m58 merge]" to the CL description? (assuming it's m58)

[Zhongyi Shi, 2017-03-27 17:52:40]

Description was changed from

==========
QUIC: mark QUIC handshake failed if connection is closed after CryptoConnect so
that QuicStreamFactory::Job will not hang.

Currently, if QuicConnection is closed during crypto_stream_->CryptConnect(),
it will silently post a task to notify QuicStreamFactory to of the session
close without notifying the QuicStreamFactory::Job. This causes
QuicStreamFactory::Job to hang. Subsequent alt jobs will be bound to the
hanging QUIC job, and will never win race over TCP and get cleaned up.

BUG=700617

Review-Url: https://codereview.chromium.org/2766603004
Cr-Commit-Position: refs/heads/master@{#459271}
(cherry picked from commit 363c91c57a5ae99e63a138555afa83dc02262325)
==========

to

==========
QUIC: mark QUIC handshake failed if connection is closed after CryptoConnect so
that QuicStreamFactory::Job will not hang.

Currently, if QuicConnection is closed during crypto_stream_->CryptConnect(),
it will silently post a task to notify QuicStreamFactory to of the session
close without notifying the QuicStreamFactory::Job. This causes
QuicStreamFactory::Job to hang. Subsequent alt jobs will be bound to the
hanging QUIC job, and will never win race over TCP and get cleaned up.

BUG=700617

Review-Url: https://codereview.chromium.org/2766603004
Cr-Commit-Position: refs/heads/master@{#459271}
(cherry picked from commit 363c91c57a5ae99e63a138555afa83dc02262325)
==========

[xunjieli, 2017-03-27 18:19:02]

Deferring this to Ryan. Thanks for taking care of the merge.

[Zhongyi Shi, 2017-03-27 18:57:56]

Description was changed from

==========
QUIC: mark QUIC handshake failed if connection is closed after CryptoConnect so
that QuicStreamFactory::Job will not hang.

Currently, if QuicConnection is closed during crypto_stream_->CryptConnect(),
it will silently post a task to notify QuicStreamFactory to of the session
close without notifying the QuicStreamFactory::Job. This causes
QuicStreamFactory::Job to hang. Subsequent alt jobs will be bound to the
hanging QUIC job, and will never win race over TCP and get cleaned up.

BUG=700617

Review-Url: https://codereview.chromium.org/2766603004
Cr-Commit-Position: refs/heads/master@{#459271}
(cherry picked from commit 363c91c57a5ae99e63a138555afa83dc02262325)
==========

to

==========
QUIC: mark QUIC handshake failed if connection is closed after CryptoConnect so
that QuicStreamFactory::Job will not hang.

Currently, if QuicConnection is closed during crypto_stream_->CryptConnect(),
it will silently post a task to notify QuicStreamFactory to of the session
close without notifying the QuicStreamFactory::Job. This causes
QuicStreamFactory::Job to hang. Subsequent alt jobs will be bound to the
hanging QUIC job, and will never win race over TCP and get cleaned up.

BUG=700617

Review-Url: https://codereview.chromium.org/2766603004
Cr-Commit-Position: refs/heads/master@{#459271}
(cherry picked from commit 363c91c57a5ae99e63a138555afa83dc02262325)

R=rch@chromium.org

Review-Url: https://codereview.chromium.org/2780523002 .
Cr-Commit-Position: refs/branch-heads/3029@{#435}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/0a4d3c147a0f52493a850051008e...
==========

[Zhongyi Shi, 2017-03-27 18:57:57]

Committed patchset #1 (id:1) manually as
0a4d3c147a0f52493a850051008e1fe57c125d30 (presubmit successful).