Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2780483002: Complain about assignments to parenthesized expressions. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Complain about assignments to parenthesized expressions. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/a91ebba20027ed5c6b65caf2cd809e887964f175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 2 chunks +27 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/token_stream_rewriter.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/testing.json View 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 9 months ago (2017-03-27 13:09:15 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-03-27 13:32:18 UTC) #3
ahe
3 years, 8 months ago (2017-03-29 08:28:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a91ebba20027ed5c6b65caf2cd809e887964f175 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698