Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2780453002: Remove deprecated Doodle search URLs (Closed)

Created:
3 years, 9 months ago by fhorschig
Modified:
3 years, 9 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated Doodle search URLs The target_url contains urls to a search, a youtube video or an fpdoodle. To provide a link on mobile, this is sufficient. Desktop uses the same target_url for static doodles and receives an HTML/JS snippet for everything else. BUG=690467 Review-Url: https://codereview.chromium.org/2780453002 Cr-Commit-Position: refs/heads/master@{#459748} Committed: https://chromium.googlesource.com/chromium/src/+/f617c93ceb1b5a6c56476d03f70832acf818e3e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M components/doodle/doodle_fetcher_impl_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M components/doodle/doodle_types.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/doodle/doodle_types.cc View 4 chunks +0 lines, -9 lines 0 comments Download
M components/doodle/doodle_types_unittest.cc View 9 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
fhorschig
3 years, 9 months ago (2017-03-27 09:36:22 UTC) #3
fhorschig
Hi Marc, would you please have a look?
3 years, 9 months ago (2017-03-27 09:37:11 UTC) #6
Marc Treib
lgtm Thanks!
3 years, 9 months ago (2017-03-27 09:37:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780453002/1
3 years, 9 months ago (2017-03-27 10:58:13 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 11:04:05 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f617c93ceb1b5a6c56476d03f708...

Powered by Google App Engine
This is Rietveld 408576698