Battery Status API: browser-side implementation.

content/browser/battery_status/battery_status_manager_interface.h

Index: content/browser/battery_status/battery_status_manager_interface.h
diff --git a/content/browser/battery_status/battery_status_manager_interface.h b/content/browser/battery_status/battery_status_manager_interface.h
new file mode 100644
index 0000000000000000000000000000000000000000..8baa8b80f6826f10511e98d6d56f0d7e0ee8bdcb
--- /dev/null
+++ b/content/browser/battery_status/battery_status_manager_interface.h
@@ -0,0 +1,25 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_BATTERY_STATUS_BATTERY_STATUS_MANAGER_INTERFACE_H_
+#define CHROME_BROWSER_BATTERY_STATUS_BATTERY_STATUS_MANAGER_INTERFACE_H_
+
+namespace content {
+
+// General interface for the Battery Status API.
+class BatteryStatusManagerInterface {

[jochen (gone - plz use gerrit), 2014/05/19 13:14:22]

it's uncommon to have classes named ...Interface. Why not just make the methods
of the concrete class virtual, so your test class can derive from the concrete
class?

[timvolodine, 2014/05/22 10:02:33]

the reason I did this is because there was a StopListeningBatteryChange() in the
destructor of battery_status_manager_android.cc, which made it impossible to
derive directly from the BatteryStatusManager class. I've currently removed the
interface, but not completely sure if that's the best way because the test now
derives directly from BatteryStatusManager which is platform-dependent so future
implementations need to be careful not to do anything hardware specific in the
header and in the destructor...

+ public:
+  BatteryStatusManagerInterface() { }
+  virtual ~BatteryStatusManagerInterface() { }
+
+  // Start listening for battery status changes.
+  virtual bool StartListeningBatteryChange() = 0;
+
+  // Stop listenting for battery status changes.

[Michael van Ouwerkerk, 2014/05/19 11:19:22]

Nit: s/listenting/listening/

[timvolodine, 2014/05/22 10:02:33]

Done.

+  virtual void StopListeningBatteryChange() = 0;
+};
+
+}  // namespace content
+
+#endif  // CHROME_BROWSER_BATTERY_STATUS_BATTERY_STATUS_MANAGER_INTERFACE_H_