content/browser/battery_status/battery_status_manager_interface.h - Issue 278043002: Battery Status API: browser-side implementation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/battery_status/battery_status_manager_interface.h

Issue 278043002: Battery Status API: browser-side implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/battery_status/battery_status_manager.h ('K') | « content/browser/battery_status/battery_status_manager.h ('k') | content/browser/battery_status/battery_status_message_filter.h » ('j') | content/browser/battery_status/battery_status_message_filter.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_BATTERY_STATUS_BATTERY_STATUS_MANAGER_INTERFACE_H_

	6 #define CHROME_BROWSER_BATTERY_STATUS_BATTERY_STATUS_MANAGER_INTERFACE_H_

	7

	8 namespace content {

	9

	10 // General interface for the Battery Status API.

	11 class BatteryStatusManagerInterface {
	jochen (gone - plz use gerrit) 2014/05/19 13:14:22 it's uncommon to have classes named ...Interface. it's uncommon to have classes named ...Interface. Why not just make the methods of the concrete class virtual, so your test class can derive from the concrete class? timvolodine 2014/05/22 10:02:33 the reason I did this is because there was a StopL Show quoted text On 2014/05/19 13:14:22, jochen wrote: > it's uncommon to have classes named ...Interface. Why not just make the methods > of the concrete class virtual, so your test class can derive from the concrete > class? the reason I did this is because there was a StopListeningBatteryChange() in the destructor of battery_status_manager_android.cc, which made it impossible to derive directly from the BatteryStatusManager class. I've currently removed the interface, but not completely sure if that's the best way because the test now derives directly from BatteryStatusManager which is platform-dependent so future implementations need to be careful not to do anything hardware specific in the header and in the destructor...
	12 public:

	13 BatteryStatusManagerInterface() { }

	14 virtual ~BatteryStatusManagerInterface() { }

	15

	16 // Start listening for battery status changes.

	17 virtual bool StartListeningBatteryChange() = 0;

	18

	19 // Stop listenting for battery status changes.
	Michael van Ouwerkerk 2014/05/19 11:19:22 Nit: s/listenting/listening/ Nit: s/listenting/listening/ timvolodine 2014/05/22 10:02:33 Done. Show quoted text On 2014/05/19 11:19:22, Michael van Ouwerkerk wrote: > Nit: s/listenting/listening/ Done.
	20 virtual void StopListeningBatteryChange() = 0;

	21 };

	22

	23 } // namespace content

	24

	25 #endif // CHROME_BROWSER_BATTERY_STATUS_BATTERY_STATUS_MANAGER_INTERFACE_H_

OLD	NEW