Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2780403003: Removed -[CRWWebDelegate webWillInitiateLoadWithParams:]. (Closed)
Patch Set: Fixed tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index 30b394fe6b6ed0095dd9fd0d6a102d1c03bac64b..9b7de51d8943cdf44daf10a60ea06ed54cab72f2 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -1062,11 +1062,11 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,
addPageVector_.clear();
}
-- (void)webWillInitiateLoadWithParams:
- (web::NavigationManager::WebLoadParams&)params {
- GURL navUrl = params.url;
-
+- (void)webDidUpdateSessionForLoadWithParams:
+ (const web::NavigationManager::WebLoadParams&)params
+ wasInitialNavigation:(BOOL)initialNavigation {
// After a crash the NTP is loaded by default.
+ GURL navUrl = params.url;
if (navUrl.host() != kChromeUINewTabHost) {
justincohen 2017/04/04 16:45:24 Do we still need to extract params.url into navUrl
Eugene But (OOO till 7-30) 2017/04/04 16:58:15 No. Done.
static BOOL hasLoadedPage = NO;
if (!hasLoadedPage) {
@@ -1078,12 +1078,7 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,
hasLoadedPage = YES;
}
}
-}
-- (void)webDidUpdateSessionForLoadWithParams:
- (const web::NavigationManager::WebLoadParams&)params
- wasInitialNavigation:(BOOL)initialNavigation {
- GURL navUrl = params.url;
ui::PageTransition transition = params.transition_type;
// Record any explicit, non-redirect navigation as a clobber (as long as it's
« no previous file with comments | « no previous file | ios/web/public/web_state/ui/crw_web_delegate.h » ('j') | ios/web/web_state/ui/crw_web_controller.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698