Removed -[CRWWebDelegate webWillInitiateLoadWithParams:].

ios/chrome/browser/tabs/tab.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/tabs/tab.h"
 
 #import <CoreLocation/CoreLocation.h>
 #import <UIKit/UIKit.h>
 
 #include <utility>
@@ skipping 1044 matching lines @@
   history::HistoryService* historyService =
       ios::HistoryServiceFactory::GetForBrowserState(
           browserState_, ServiceAccessType::IMPLICIT_ACCESS);
   DCHECK(historyService);
 
   for (size_t i = 0; i < addPageVector_.size(); ++i)
     historyService->AddPage(addPageVector_[i]);
   addPageVector_.clear();
 }
 
-- (void)webWillInitiateLoadWithParams:
-    (web::NavigationManager::WebLoadParams&)params {
+- (void)webDidUpdateSessionForLoadWithParams:
+            (const web::NavigationManager::WebLoadParams&)params
+                        wasInitialNavigation:(BOOL)initialNavigation {
+  // After a crash the NTP is loaded by default.
   GURL navUrl = params.url;
-
-  // After a crash the NTP is loaded by default.
   if (navUrl.host() != kChromeUINewTabHost) {

[justincohen, 2017/04/04 16:45:24]

Do we still need to extract params.url into navUrl?  

[Eugene But (OOO till 7-30), 2017/04/04 16:58:15]

No. Done.

     static BOOL hasLoadedPage = NO;
     if (!hasLoadedPage) {
       // As soon as an URL is loaded, a crash shouldn't be counted as a startup

[Eugene But (OOO till 7-30), 2017/04/04 16:58:15]

Actually this comment is not correct and was not correct. At this point URL is
not loaded yet, in fact the load did not even start. Updated the comment.

[justincohen, 2017/04/04 17:08:13]

I think the meaning behind 'load' means initiate load, e.g. user action
initiated.

       // crash. Since loading an url requires user action and is a significant
       // source of crashes that could lead to false positives in crash loop
       // detection.
       crash_util::ResetFailedStartupAttemptCount();
       hasLoadedPage = YES;
     }
   }
-}
 
-- (void)webDidUpdateSessionForLoadWithParams:
-            (const web::NavigationManager::WebLoadParams&)params
-                        wasInitialNavigation:(BOOL)initialNavigation {
-  GURL navUrl = params.url;
   ui::PageTransition transition = params.transition_type;
 
   // Record any explicit, non-redirect navigation as a clobber (as long as it's
   // in a real tab).
   if (!initialNavigation && !isPrerenderTab_ &&
       !PageTransitionCoreTypeIs(transition, ui::PAGE_TRANSITION_RELOAD) &&
       (transition & ui::PAGE_TRANSITION_IS_REDIRECT_MASK) == 0) {
     base::RecordAction(UserMetricsAction("MobileTabClobbered"));
   }
   if ([parentTabModel_ tabUsageRecorder])
@@ skipping 998 matching lines @@
 
 - (TabModel*)parentTabModel {
   return parentTabModel_;
 }
 
 - (FormInputAccessoryViewController*)inputAccessoryViewController {
   return inputAccessoryViewController_.get();
 }
 
 @end