Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2780393006: Open IOHIDDevices on the FILE thread (Closed)

Created:
3 years, 8 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Open IOHIDDevices on the FILE thread Calling IOHIDDeviceCreate to open a HID device may jank the UI thread so the task should be executed on the FILE thread during the creation of a new HidConnection. BUG=706573 Review-Url: https://codereview.chromium.org/2780393006 Cr-Commit-Position: refs/heads/master@{#460920} Committed: https://chromium.googlesource.com/chromium/src/+/c2d8b871f3810ec01394eee986b02bc400b36db7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -18 lines) Patch
M device/hid/hid_connection_mac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/hid/hid_connection_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/hid/hid_service_mac.h View 4 chunks +13 lines, -0 lines 0 comments Download
M device/hid/hid_service_mac.cc View 5 chunks +32 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Reilly Grant (use Gerrit)
Please take a look.
3 years, 8 months ago (2017-03-30 21:46:00 UTC) #3
erikchen
lgtm
3 years, 8 months ago (2017-03-30 21:59:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780393006/1
3 years, 8 months ago (2017-03-30 22:01:14 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 23:17:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2d8b871f3810ec01394eee986b0...

Powered by Google App Engine
This is Rietveld 408576698