Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2780393005: Move the canonical empty context to the VM isolate. (Closed)

Created:
3 years, 8 months ago by rmacnak
Modified:
3 years, 8 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -38 lines) Patch
M runtime/vm/clustered_snapshot.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_dbc.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/object.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 7 chunks +17 lines, -12 lines 0 comments Download
M runtime/vm/object_store.h View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/object_store.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/snapshot.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/snapshot_ids.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
3 years, 8 months ago (2017-03-30 19:41:09 UTC) #3
Florian Schneider
Lgtm.
3 years, 8 months ago (2017-03-30 20:25:32 UTC) #4
rmacnak
3 years, 8 months ago (2017-03-31 21:43:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a2c41bd92609517ee9c404343d6bd88a2f95b23d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698